HDFS-17197. Show file replication when listing corrupt files. #6095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Hexiaoqiao
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Thanks @zhangshuyan0 for your contribution. Leave nit comments inline, FYI.
| corruptFiles.add(new CorruptFileBlockInfo(src, blk)); | ||
| int repl = 0; | ||
| if (inode.isFile()) { | ||
| repl = inode.asFile().getFileReplication(); |
There was a problem hiding this comment.
What will be return if this inode is one EC file here?
There was a problem hiding this comment.
Oh, I forgot to take this situation into account. How about printing -1 in CorruptFileBlockInfo when this is a EC file?
There was a problem hiding this comment.
Add another attribution about ec policy and with this attribution when meet ec file, what do you think about?
There was a problem hiding this comment.
I think it's ok. I've updated this PR. Please take a look when you free.
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return block.getBlockName() + "\t" + path; | ||
| return block.getBlockName() + "\t" + replication + "\t" + path; |
There was a problem hiding this comment.
I am a little worried about the compatibility while upstream dependency with this string but we change the format here.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Hexiaoqiao
approved these changes
Sep 22, 2023
|
Committed to trunk. Thanks @zhangshuyan0 . |
|
Addendum: the failed unit test is not related to this PR. |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
…#6095). Contributed by Shuyan Zhang. Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Files with different replication have different reliability guarantees. We need to pay attention to corrupted files with a specified replication greater than or equal to 3. So, when listing corrupt files, it would be useful to display the corresponding replication of the files.