HADOOP-18861 ABFS: Fix failing tests for CPK #5979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:::: AGGREGATED TEST RESULT :::: HNS-OAuth[INFO] Results: HNS-SharedKey[INFO] Results: NonHNS-SharedKey[INFO] Results: AppendBlob-HNS-OAuth[INFO] Results: Time taken: 35 mins 24 secs. |
There was a problem hiding this comment.
path() usage in test was added as part of #3153.
Should we do:
path("/" + methodName.getMethodName()).toUri().getPath();
since, AbstractAbfsIntegerationTest.path() already has heurisitc of having random string.
Taken |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
| @@ -382,6 +382,7 @@ public void testConfigPropNotFound() throws Throwable { | |||
|
|
|||
| for (String key : CONFIG_KEYS) { | |||
| setAuthConfig(abfsConf, true, AuthType.OAuth); | |||
| abfsConf.unset(key); | |||
There was a problem hiding this comment.
Can you please share in description why we are unsetting it. Does this get ignored somehow in current tests.
There was a problem hiding this comment.
This is a fix for this test failure :- TestAccountConfiguration.testConfigPropNotFound:386->testMissingConfigKey:399 Expected a org.apache.hadoop.fs.azurebfs.contracts.exceptions.TokenAccessProviderException to be thrown, but got the result: : "org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider"
anmolanmol1234
changed the title
|
Hi @steveloughran can you please help in check-in of this PR to resolve the existing test failures ? Thanks. |
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
requested changes
Sep 7, 2023
| @@ -112,7 +112,7 @@ public ITestCustomerProvidedKey() throws Exception { | |||
| @Test | |||
| public void testReadWithCPK() throws Exception { | |||
| final AzureBlobFileSystem fs = getAbfs(true); | |||
| String fileName = path("/" + methodName.getMethodName()).toString(); | |||
| String fileName = path("/" + methodName.getMethodName()).toUri().getPath(); | |||
There was a problem hiding this comment.
provide a single method for this, use it everywhere
|
🎊 +1 overall
This message was automatically generated. |
|
merged to trunk; do a pr against branch-3.3 and retest and i'll merge that too |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
Contributed by Anmol Asrani
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CPK tests, file name having absolute path results in Invalid URI error. The fix includes changing that to relative path.