-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11535: Jackson-dataformat-yaml should be upgraded to 2.15.2 as it may cause transitive dependency issue with 2.12.7 #5884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
| </dependency> | ||
| <dependency> | ||
| <groupId>org.yaml</groupId> | ||
| <artifactId>snakeyaml</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead of this exclusion, we should update com.fasterxml.jackson.dataformat to 2.15.2 version which uses snakeyaml 2.0.
https://mvnrepository.com/artifact/com.fasterxml.jackson.dataformat/jackson-dataformat-yaml/2.15.2
Can we try that option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomicooler Yes, but this needed to be fixed for other jackson related dependency altogether having <jackson2.version>2.12.7</jackson2.version> ,
Line 72 in 5aee0e0
| <jackson2.version>2.12.7</jackson2.version> |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
tomicooler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
Please reword the PR title.
|
Thanks @susheelgupta7 for the patch, @tomicooler for the review. Merging to trunk. |
…5.2 as it may cause transitive dependency issue with 2.12.7 (apache#5884)" This reverts commit 35af8b9.
…t may cause transitive dependency issue with 2.12.7 (apache#5884)
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?