Skip to content

HADOOP-18779. Improve hadoop-function.sh#status script. #5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Jun 21, 2023

Description of PR

JIRA: HADOOP-18779. Improve hadoop-function.sh#status script.

When We use yarn --daemon status router/nodemanager, I found that no information can be displayed. I checked the script and modified the script of hadoop-functions.sh#status to increase the output information.

yarn --daemon status router

  • If the service is started, the following information will be printed.
router is running as process 47626.
  • If the service is stop, the following information will be printed.
router is stopped.

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 ❌ mvninstall 12m 14s /branch-mvninstall-root.txt root in trunk failed.
+1 💚 mvnsite 1m 33s trunk passed
+1 💚 shadedclient 30m 53s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 30s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 56s the patch passed
-1 ❌ shellcheck 0m 5s /results-shellcheck.txt The patch generated 1 new + 26 unchanged - 0 fixed = 27 total (was 26)
+1 💚 shadedclient 24m 14s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 1m 35s hadoop-common in the patch passed.
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
79m 58s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5762/1/artifact/out/Dockerfile
GITHUB PR #5762
Optional Tests dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs
uname Linux 3402a667840c 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d9d95b4
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5762/1/testReport/
Max. process+thread count 536 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5762/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri
Copy link
Member

goiri commented Jun 21, 2023

I wonder if not outputting anything was done by design.
I can see the case for a daemon not outputting anything.

@slfan1989
Copy link
Contributor Author

I wonder if not outputting anything was done by design.
I can see the case for a daemon not outputting anything.

Thanks for your explanation! I will use this command again in the test environment.

@slfan1989
Copy link
Contributor Author

slfan1989 commented Jun 22, 2023

@goiri I have carefully read the code related to the --daemon and conducted experiments in a testing environment.

The daemon of hdfs/yarn contains 3 operations, namely start|status|stop

  • hdfs --daemon start namenode

When starting the namenode, we can use the command hdfs --daemon start namenode, which initiates the namenode without generating any output information. I believe this behavior is appropriate.

image
  • hdfs --daemon status namenode

When utilizing the hdfs --daemon status namenode command, I still expect it to provide some information regarding the namenode's status. Nevertheless, I have noticed that executing this command does not yield any output.

image

I have added some output information for the status command.

  • If the service is in a running state.
image
  • If the service is in a stopped state.
image

This modification only affects the status command of the daemon and does not have any impact on the start or stop commands.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 52m 31s trunk passed
+1 💚 mvnsite 1m 30s trunk passed
+1 💚 shadedclient 37m 19s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 59s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 18s the patch passed
-1 ❌ shellcheck 0m 4s /results-shellcheck.txt The patch generated 1 new + 26 unchanged - 0 fixed = 27 total (was 26)
+1 💚 shadedclient 37m 37s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 1m 35s hadoop-common in the patch passed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
138m 57s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5762/2/artifact/out/Dockerfile
GITHUB PR #5762
Optional Tests dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs
uname Linux 2bea028ff82b 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / b1ce3d5
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5762/2/testReport/
Max. process+thread count 530 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5762/2/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri goiri merged commit e8590ad into apache:trunk Jul 3, 2023
@slfan1989
Copy link
Contributor Author

@goiri Thank you very much for your help in reviewing the code!

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants