Skip to content

HDDS-1219. TestContainerActionsHandler.testCloseContainerAction has an intermittent failure #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

elek
Copy link
Member

@elek elek commented Mar 5, 2019

It's failed multiple times during the CI builds:

{code}
Error Message

Wanted but not invoked:
closeContainerEventHandler.onMessage(
#1,
org.apache.hadoop.hdds.server.events.EventQueue@3d3fcdb0
);
-> at org.apache.hadoop.hdds.scm.container.TestContainerActionsHandler.testCloseContainerAction(TestContainerActionsHandler.java:64)
Actually, there were zero interactions with this mock.
{code}

The fix is easy: we should call queue.processAll(1000L) to wait for the processing of all the events.

See: https://issues.apache.org/jira/browse/HDDS-1219

…n intermittent failure. Contributed by Elek, Marton.
@elek elek added the ozone label Mar 5, 2019
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 69 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1356 trunk passed
+1 compile 61 trunk passed
+1 checkstyle 26 trunk passed
+1 mvnsite 38 trunk passed
+1 shadedclient 842 branch has no errors when building and testing our client artifacts.
+1 findbugs 58 trunk passed
+1 javadoc 28 trunk passed
_ Patch Compile Tests _
+1 mvninstall 61 the patch passed
+1 compile 29 the patch passed
+1 javac 29 the patch passed
+1 checkstyle 17 the patch passed
+1 mvnsite 34 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 872 patch has no errors when building and testing our client artifacts.
+1 findbugs 53 the patch passed
+1 javadoc 23 the patch passed
_ Other Tests _
+1 unit 138 server-scm in the patch passed.
+1 asflicense 32 The patch does not generate ASF License warnings.
3858
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-555/1/artifact/out/Dockerfile
GITHUB PR #555
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 45fdd96c8548 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 0aefe28
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-555/1/testReport/
Max. process+thread count 457 (vs. ulimit of 5500)
modules C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-555/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@arp7
Copy link
Contributor

arp7 commented Mar 5, 2019

LGTM.

@arp7
Copy link
Contributor

arp7 commented Mar 5, 2019

+1

@arp7 arp7 merged commit df99137 into apache:trunk Mar 5, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Refactored metrics for table API
 - Added TableMetricsUtil that encapsulates required parameters, maintains naming consistency and simplifies metrics creation API for tables.
 - Added metrics to local table
 - Maintained consistency between local, remote and caching table

Author: Wei Song <wsong@wsong-mn2.linkedin.biz>

Reviewers: Peng Du<pdu@linkedin.com>

Closes apache#555 from weisong44/table-metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants