HDFS-16943. RBF: Implements MySQL based StateStoreDriver. #5469

simbadzina · 2023-03-09T18:24:13Z

Description of PR

RBF supports two types of StateStoreDrivers

StateStoreFileImpl
StateStoreZooKeeperImpl

This PR implements a third driver that is backed by MySQL.

StateStoreZooKeeperImpl requires an additional Zookeeper cluster.
StateStoreFileImpl can use one of the namenodes in the HDFS cluster, but that namenode becomes a single point of failure, introducing coupling between the federated clusters.

HADOOP-18535 implemented a MySQL token store. When tokens are stored in MySQL, using MySQL for the StateStore as well reduces the number of external dependencies for routers.

How was this patch tested?

New tests in TestStateStoreMySQL

For code changes:

[X ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

virajjasani · 2023-03-09T18:42:13Z

Using MySQL too is an external dependency, just like Zookeeper. I wonder if we should make StateStoreDrive IA.Public for others to extend it. Similar to MySQL, one should be able to use postgres and other databases too, but each impl might bring too much of external dependencies in hadoop, making the dependency management difficult over a period of time (more transitive CVE exposures?). WDYT?
For this one though, it's still manageable as mysql dependencies are already added (for token store impl).

cc @goiri @slfan1989

virajjasani · 2023-03-09T18:49:40Z

I don't have much insights into Yarn federation but it looks like Yarn does have SQLFederationStateStore (it uses HikariDataSource) and one of the impl MySQLFederationStateStore is in test code.

Perhaps keeping MySQL specific impl in test was meant to be set as an example only? @slfan1989 might have better insights.

I don't mean anything against this change btw, I just wonder how we could manage ever increasing num of external dependencies such that we could allow more pluggable implementation to be used by different users without hadoop having to take up more external dependencies :)

simbadzina · 2023-03-09T19:46:14Z

Using MySQL too is an external dependency, just like Zookeeper. I wonder if we should make StateStoreDrive IA.Public for others to extend it. Similar to MySQL, one should be able to use postgres and other databases too, but each impl might bring too much of external dependencies in hadoop, making the dependency management difficult over a period of time (more transitive CVE exposures?). WDYT? For this one though, it's still manageable as mysql dependencies are already added (for token store impl).

cc @goiri @slfan1989

Yes, I agree it an external dependency. The desire it to depend on just one system MySQL for both the StateStore and DelegationTokens(HADOOP-18535).

So StateStoreDriver is already public and can be configured with dfs.federation.router.store.driver.class .
I just tested moving my new class to a separate package and all the utilities I accessed are still reachable.

hadoop-yetus · 2023-03-09T20:23:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 58s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 14s		trunk passed
+1 💚	compile	0m 46s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	0m 43s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	0m 35s		trunk passed
+1 💚	mvnsite	0m 47s		trunk passed
+1 💚	javadoc	0m 54s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 56s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 36s		trunk passed
+1 💚	shadedclient	20m 44s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 35s		the patch passed
+1 💚	compile	0m 39s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	0m 39s		the patch passed
+1 💚	compile	0m 32s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	0m 32s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 3 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	0m 19s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)
+1 💚	mvnsite	0m 38s		the patch passed
+1 💚	javadoc	0m 33s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 49s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
-1 ❌	spotbugs	1m 23s	/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html	hadoop-hdfs-project/hadoop-hdfs-rbf generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
+1 💚	shadedclient	20m 33s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	22m 3s		hadoop-hdfs-rbf in the patch passed.
-1 ❌	asflicense	0m 38s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		118m 8s

Reason	Tests
SpotBugs	module:hadoop-hdfs-project/hadoop-hdfs-rbf
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.CONNECTION_DRIVER isn't final but should be At StateStoreMySQLImpl.java:be At StateStoreMySQLImpl.java:[line 63]
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.CONNECTION_PASSWORD isn't final but should be At StateStoreMySQLImpl.java:be At StateStoreMySQLImpl.java:[line 62]
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.CONNECTION_URL isn't final but should be At StateStoreMySQLImpl.java:be At StateStoreMySQLImpl.java:[line 60]
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.CONNECTION_USERNAME isn't final but should be At StateStoreMySQLImpl.java:be At StateStoreMySQLImpl.java:[line 61]
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.get(Class) may fail to clean up java.sql.Statement Obligation to clean up resource created at StateStoreMySQLImpl.java:up java.sql.Statement Obligation to clean up resource created at StateStoreMySQLImpl.java:[line 137] is not discharged
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.get(Class) may fail to close PreparedStatement At StateStoreMySQLImpl.java:PreparedStatement At StateStoreMySQLImpl.java:[line 137]

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/1/artifact/out/Dockerfile
GITHUB PR	#5469
Optional Tests	dupname asflicense codespell detsecrets compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle
uname	Linux 53f707ecd1ef 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bcb399a`
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/1/testReport/
Max. process+thread count	2872 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-03-09T20:24:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 30s		trunk passed
+1 💚	compile	0m 45s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	0m 41s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	0m 35s		trunk passed
+1 💚	mvnsite	0m 47s		trunk passed
+1 💚	javadoc	0m 52s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	1m 0s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 33s		trunk passed
+1 💚	shadedclient	20m 44s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 35s		the patch passed
+1 💚	compile	0m 36s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	0m 36s		the patch passed
+1 💚	compile	0m 31s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	0m 31s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 19s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)
+1 💚	mvnsite	0m 37s		the patch passed
+1 💚	javadoc	0m 35s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 53s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
-1 ❌	spotbugs	1m 25s	/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html	hadoop-hdfs-project/hadoop-hdfs-rbf generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
+1 💚	shadedclient	20m 32s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	20m 31s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 38s		The patch does not generate ASF License warnings.
		115m 4s

Reason	Tests
SpotBugs	module:hadoop-hdfs-project/hadoop-hdfs-rbf
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.CONNECTION_DRIVER isn't final but should be At StateStoreMySQLImpl.java:be At StateStoreMySQLImpl.java:[line 63]
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.CONNECTION_PASSWORD isn't final but should be At StateStoreMySQLImpl.java:be At StateStoreMySQLImpl.java:[line 62]
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.CONNECTION_URL isn't final but should be At StateStoreMySQLImpl.java:be At StateStoreMySQLImpl.java:[line 60]
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.CONNECTION_USERNAME isn't final but should be At StateStoreMySQLImpl.java:be At StateStoreMySQLImpl.java:[line 61]
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.get(Class) may fail to clean up java.sql.Statement Obligation to clean up resource created at StateStoreMySQLImpl.java:up java.sql.Statement Obligation to clean up resource created at StateStoreMySQLImpl.java:[line 137] is not discharged
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.get(Class) may fail to close PreparedStatement At StateStoreMySQLImpl.java:PreparedStatement At StateStoreMySQLImpl.java:[line 137]

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/2/artifact/out/Dockerfile
GITHUB PR	#5469
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux e1bdc47dd780 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bd6a3b0`
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/2/testReport/
Max. process+thread count	2548 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-03-09T20:51:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	17m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 6s		trunk passed
+1 💚	compile	0m 42s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	0m 37s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	0m 30s		trunk passed
+1 💚	mvnsite	0m 42s		trunk passed
+1 💚	javadoc	0m 47s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 53s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 33s		trunk passed
+1 💚	shadedclient	23m 36s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 34s		the patch passed
+1 💚	compile	0m 36s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	0m 36s		the patch passed
+1 💚	compile	0m 30s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	0m 30s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 17s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)
+1 💚	mvnsite	0m 35s		the patch passed
+1 💚	javadoc	0m 32s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 50s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
-1 ❌	spotbugs	1m 26s	/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html	hadoop-hdfs-project/hadoop-hdfs-rbf generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
+1 💚	shadedclient	23m 45s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	21m 23s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		140m 37s

Reason	Tests
SpotBugs	module:hadoop-hdfs-project/hadoop-hdfs-rbf
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.CONNECTION_DRIVER isn't final but should be At StateStoreMySQLImpl.java:be At StateStoreMySQLImpl.java:[line 63]
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.CONNECTION_PASSWORD isn't final but should be At StateStoreMySQLImpl.java:be At StateStoreMySQLImpl.java:[line 62]
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.CONNECTION_URL isn't final but should be At StateStoreMySQLImpl.java:be At StateStoreMySQLImpl.java:[line 60]
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.CONNECTION_USERNAME isn't final but should be At StateStoreMySQLImpl.java:be At StateStoreMySQLImpl.java:[line 61]
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.get(Class) may fail to clean up java.sql.Statement Obligation to clean up resource created at StateStoreMySQLImpl.java:up java.sql.Statement Obligation to clean up resource created at StateStoreMySQLImpl.java:[line 137] is not discharged
	org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.get(Class) may fail to close PreparedStatement At StateStoreMySQLImpl.java:PreparedStatement At StateStoreMySQLImpl.java:[line 137]

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/3/artifact/out/Dockerfile
GITHUB PR	#5469
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 558a8ceabd9e 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bd6a3b0`
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/3/testReport/
Max. process+thread count	2426 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

virajjasani · 2023-03-09T22:37:01Z

So StateStoreDriver is already public and can be configured with dfs.federation.router.store.driver.class .

Correct, what I meant above by this "StateStoreDrive IA.Public for others to extend it" is that we can make StateStoreDrive as @InterfaceAudience.Public and that way we officially allow other applications to extend it.

simbadzina · 2023-03-10T00:53:02Z

Correct, what I meant above by this "StateStoreDrive IA.Public for others to extend it" is that we can make StateStoreDrive as @InterfaceAudience.Public and that way we officially allow other applications to extend it.

I see. I think that is a good idea. With that change do you think the MySQLStateStore would still be valuable to the community?

simbadzina · 2023-03-10T01:02:22Z

@virajjasani for making the StateStoreDrvier interface public, do you think we should then also do the same for
StateStoreSerializableImpl and StateStoreBaseImpl? I assume this would limit our flexibility in changing these since we'll need to make change backward compatible.

hadoop-yetus · 2023-03-10T03:12:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 18s		trunk passed
+1 💚	compile	0m 45s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	0m 41s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	0m 33s		trunk passed
+1 💚	mvnsite	0m 46s		trunk passed
+1 💚	javadoc	0m 53s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 58s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 36s		trunk passed
+1 💚	shadedclient	20m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 35s		the patch passed
+1 💚	compile	0m 36s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	0m 36s		the patch passed
+1 💚	compile	0m 33s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	0m 33s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 19s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	mvnsite	0m 36s		the patch passed
+1 💚	javadoc	0m 33s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 50s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
-1 ❌	spotbugs	1m 23s	/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html	hadoop-hdfs-project/hadoop-hdfs-rbf generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	shadedclient	20m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	20m 22s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		115m 39s

Reason	Tests
SpotBugs	module:hadoop-hdfs-project/hadoop-hdfs-rbf
	Exception is caught when Exception is not thrown in org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.get(Class) At StateStoreMySQLImpl.java:is not thrown in org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreMySQLImpl.get(Class) At StateStoreMySQLImpl.java:[line 145]

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/4/artifact/out/Dockerfile
GITHUB PR	#5469
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux b1fcfb25c1e4 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `c656973`
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/4/testReport/
Max. process+thread count	2668 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-03-10T05:52:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 58s		trunk passed
+1 💚	compile	0m 45s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	0m 41s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	0m 35s		trunk passed
+1 💚	mvnsite	0m 47s		trunk passed
+1 💚	javadoc	0m 52s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	1m 1s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 34s		trunk passed
+1 💚	shadedclient	20m 51s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 36s		the patch passed
+1 💚	compile	0m 37s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	0m 37s		the patch passed
+1 💚	compile	0m 31s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	0m 31s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 18s		the patch passed
+1 💚	mvnsite	0m 34s		the patch passed
+1 💚	javadoc	0m 33s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 51s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 20s		the patch passed
+1 💚	shadedclient	20m 21s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	20m 22s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		115m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/5/artifact/out/Dockerfile
GITHUB PR	#5469
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 02fa309ff9b0 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `c46e685`
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/5/testReport/
Max. process+thread count	2798 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-03-31T19:51:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 3s		trunk passed
+1 💚	compile	0m 45s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	0m 40s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	0m 34s		trunk passed
+1 💚	mvnsite	0m 45s		trunk passed
+1 💚	javadoc	0m 51s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 59s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 31s		trunk passed
+1 💚	shadedclient	20m 50s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 34s		the patch passed
+1 💚	compile	0m 36s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	0m 36s		the patch passed
+1 💚	compile	0m 32s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	0m 32s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 19s		the patch passed
+1 💚	mvnsite	0m 35s		the patch passed
+1 💚	javadoc	0m 33s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 50s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 21s		the patch passed
+1 💚	shadedclient	20m 21s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	21m 52s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		116m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/6/artifact/out/Dockerfile
GITHUB PR	#5469
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux f371cf3fd382 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a1e01f7`
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/6/testReport/
Max. process+thread count	3010 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/6/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

...bf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/StateStoreDriver.java

...ain/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreMySQLImpl.java

hadoop-yetus · 2023-04-01T03:45:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 1s		trunk passed
+1 💚	compile	0m 46s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	0m 41s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	0m 35s		trunk passed
+1 💚	mvnsite	0m 46s		trunk passed
+1 💚	javadoc	0m 51s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	1m 0s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 31s		trunk passed
+1 💚	shadedclient	20m 46s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 35s		the patch passed
+1 💚	compile	0m 36s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	0m 36s		the patch passed
+1 💚	compile	0m 32s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	0m 32s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 19s		the patch passed
+1 💚	mvnsite	0m 34s		the patch passed
+1 💚	javadoc	0m 33s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 50s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 19s		the patch passed
+1 💚	shadedclient	20m 16s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	20m 6s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		114m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/7/artifact/out/Dockerfile
GITHUB PR	#5469
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux d200aead90e9 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `edf45fc`
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/7/testReport/
Max. process+thread count	2775 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/7/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

simbadzina · 2023-04-03T17:25:49Z

@virajjasani I've annotated the StateStoreDriver interfaces as Public. Could you please do another review of the code.

...bf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/StateStoreDriver.java

...main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreBaseImpl.java

virajjasani · 2023-04-03T20:39:08Z

@simbadzina sorry I had the comment but somehow I forgot to complete the review, hence they didn't come to the PR.

simbadzina · 2023-04-03T20:57:26Z

@simbadzina sorry I had the comment but somehow I forgot to complete the review, hence they didn't come to the PR.

No worries, thanks for the review.

virajjasani

Left minor nits, looks good otherwise

...ain/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreMySQLImpl.java

virajjasani · 2023-04-03T21:15:39Z

+1 (non-binding), pending QA. Thanks @simbadzina

hadoop-yetus · 2023-04-03T22:54:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 59s		trunk passed
+1 💚	compile	0m 44s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	0m 40s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	0m 34s		trunk passed
+1 💚	mvnsite	0m 47s		trunk passed
+1 💚	javadoc	0m 52s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	1m 1s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 32s		trunk passed
+1 💚	shadedclient	20m 47s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 34s		the patch passed
+1 💚	compile	0m 35s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	0m 35s		the patch passed
+1 💚	compile	0m 32s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	0m 32s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 18s		the patch passed
+1 💚	mvnsite	0m 35s		the patch passed
+1 💚	javadoc	0m 33s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 52s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 19s		the patch passed
+1 💚	shadedclient	20m 17s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	21m 49s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 38s		The patch does not generate ASF License warnings.
		116m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/8/artifact/out/Dockerfile
GITHUB PR	#5469
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux b15999310acf 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bbc56ea`
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/8/testReport/
Max. process+thread count	2793 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/8/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-04-03T23:13:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	42m 58s		trunk passed
+1 💚	compile	0m 44s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	0m 40s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	0m 34s		trunk passed
+1 💚	mvnsite	0m 45s		trunk passed
+1 💚	javadoc	0m 51s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 58s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 33s		trunk passed
+1 💚	shadedclient	20m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 35s		the patch passed
+1 💚	compile	0m 36s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	0m 36s		the patch passed
+1 💚	compile	0m 31s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	0m 31s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 19s		the patch passed
+1 💚	mvnsite	0m 36s		the patch passed
+1 💚	javadoc	0m 32s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 50s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	1m 20s		the patch passed
+1 💚	shadedclient	20m 29s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	20m 26s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		118m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/9/artifact/out/Dockerfile
GITHUB PR	#5469
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 7c07452c2932 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6313d0a`
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/9/testReport/
Max. process+thread count	2543 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5469/9/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

simbadzina · 2023-04-04T20:04:43Z

@tasanuma could you please take a look at this pull request when you can. Thanks.

simbadzina · 2023-04-04T20:36:33Z

Thanks @goiri for the review and approval. Could you please squash and merge the commits when appropriate.

goiri · 2023-04-05T21:08:30Z

@virajjasani do you mind approving?

virajjasani

+1 (non-binding)

virajjasani · 2023-04-05T21:32:45Z

Sorry I did +1 but it was only comment. The changes look good for 3.4.0. Thank you @goiri @simbadzina !!

simbadzina · 2023-04-06T02:44:13Z

Thank you for the reviews @virajjasani @goiri .

(Cherry-picked from 47c22e3) ACLOVERRIDE

HDFS-16943. RBF: Implements MySQL based StateStoreDriver.

bd6a3b0

simbadzina force-pushed the sdzinama/HDFS-16943 branch from bcb399a to bd6a3b0 Compare March 9, 2023 18:29

Fixing checkstyle and spotbug errors.

c656973

Fixing checkstyle and spotbug warnings

c46e685

Makes StateStoreDriver interfaces public.

a1e01f7

goiri reviewed Mar 31, 2023

View reviewed changes

Adds unit on time variables.

edf45fc

simbadzina requested a review from goiri April 3, 2023 15:13

virajjasani reviewed Apr 3, 2023

View reviewed changes

...bf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/StateStoreDriver.java Show resolved Hide resolved

...main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreBaseImpl.java Show resolved Hide resolved

Annotates the StateStoreDriver interfaces as still evolving.

bbc56ea

virajjasani reviewed Apr 3, 2023

View reviewed changes

...ain/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreMySQLImpl.java Outdated Show resolved Hide resolved

...ain/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreMySQLImpl.java Show resolved Hide resolved

Removes static import and makes use of Time.monotonicNow() consistent

6313d0a

goiri approved these changes Apr 4, 2023

View reviewed changes

virajjasani approved these changes Apr 5, 2023

View reviewed changes

goiri merged commit 47c22e3 into apache:trunk Apr 5, 2023

simbadzina deleted the sdzinama/HDFS-16943 branch April 6, 2023 02:44

ferdelyi pushed a commit to ferdelyi/hadoop that referenced this pull request May 26, 2023

HDFS-16943. RBF: Implements MySQL based StateStoreDriver. (apache#5469)

b47c09a

NyteKnight pushed a commit to NyteKnight/hadoop that referenced this pull request Jun 25, 2024

HDFS-16943. RBF: Implements MySQL based StateStoreDriver. (apache#5469)

4dfff4a

(Cherry-picked from 47c22e3) ACLOVERRIDE

HDFS-16943. RBF: Implements MySQL based StateStoreDriver. #5469

HDFS-16943. RBF: Implements MySQL based StateStoreDriver. #5469

Uh oh!

Conversation

simbadzina commented Mar 9, 2023 • edited by goiri Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

virajjasani commented Mar 9, 2023

Uh oh!

virajjasani commented Mar 9, 2023

Uh oh!

simbadzina commented Mar 9, 2023

Uh oh!

hadoop-yetus commented Mar 9, 2023

Uh oh!

hadoop-yetus commented Mar 9, 2023

Uh oh!

hadoop-yetus commented Mar 9, 2023

Uh oh!

virajjasani commented Mar 9, 2023

Uh oh!

simbadzina commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simbadzina commented Mar 10, 2023

Uh oh!

hadoop-yetus commented Mar 10, 2023

Uh oh!

hadoop-yetus commented Mar 10, 2023

Uh oh!

hadoop-yetus commented Mar 31, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hadoop-yetus commented Apr 1, 2023

Uh oh!

simbadzina commented Apr 3, 2023

Uh oh!

Uh oh!

Uh oh!

virajjasani commented Apr 3, 2023

Uh oh!

simbadzina commented Apr 3, 2023

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

virajjasani commented Apr 3, 2023

Uh oh!

hadoop-yetus commented Apr 3, 2023

Uh oh!

hadoop-yetus commented Apr 3, 2023

Uh oh!

simbadzina commented Apr 4, 2023

Uh oh!

simbadzina commented Apr 4, 2023

Uh oh!

goiri commented Apr 5, 2023

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Apr 5, 2023

Uh oh!

simbadzina commented Apr 6, 2023

Uh oh!

Uh oh!

simbadzina commented Mar 9, 2023 •

edited by goiri

Loading

simbadzina commented Mar 10, 2023 •

edited

Loading