-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDFS-16887 Log start and end of phase/step in startup progress #5292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, pending CI.
Thank you, @virajjasani !
💔 -1 overall
This message was automatically generated. |
Signed-off-by: Chris Nauroth <cnauroth@apache.org> (cherry picked from commit 1263e02)
The CI run had an unrelated test failure. I have committed this to trunk, branch-3.3 and branch-3.2. @virajjasani , thank you for contributing the patch. |
Agree. Thank you for reviewing and merging the PR @cnauroth ! |
As part of Namenode startup progress, we have multiple phases and steps within phase that are instantiated. While the startup progress view can be instantiated with the current view of phase/step, having at least DEBUG logs for startup progress would be helpful to identify when a particular step for LOADING_FSIMAGE/SAVING_CHECKPOINT/LOADING_EDITS was started and ended.