HADOOP-16150. ChecksumFileSystem doesn't wrap concat() #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't have checksums. Contributed by Steve Loughran. Change-Id: I85fc1fc9445ca0b7d325495d3bc55fe9f5e5ce52
steveloughran
changed the title
|
🎊 +1 overall
This message was automatically generated. |
|
@steveloughran I committed this to trunk using cherry-pick on gitbox. I don't have access to my Apache linked github account from work that makes github workflow a pain to use. Please close this pull request. Thanks |
|
done
No? Not even from a different browser window? |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
1. Currently coordination related state is spread across several Zookeeper classes. There are also back-and-forth flows that exist between the ZkJobCoordinator, ZkControllerImpl, ZkControllerListener and ZkLeaderElector. This PR nukes un-necessary interfaces (and their implementation classes), simplifies state management and unifies state in the ZkJobCoordinator class. 2. Clearly defined life-cycle hooks on events: - Protocol validations happen once during the lifecycle of a StreamProcessor (instead of each new session) - New subscriptions to listeners happen at each a new Zk session Author: Jagadish <jvenkatraman@linkedin.com> Reviewers: Prateek M<pmaheshw@linkedin.com> Closes apache#525 from vjagadish/zk-simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HADOOP-16150. ChecksumFileSystem doesn't wrap concat()
This intercepts concat() To throw an UnsupportedOperationException.
Without this the concat() call is passes straight down to the wrapped
FS, so, if the underlying FS does support concat(), concatenated files don't have checksums
It also disables the test TestLocalFSContractMultipartUploader, as the service-loader mechanism to create an MPU uploader needs to be replaced by an API call in the filesystems, as proposed by HDFS-13934
Contributed by Steve Loughran.
Change-Id: I85fc1fc9445ca0b7d325495d3bc55fe9f5e5ce52