Skip to content

HDDS-1180. TestRandomKeyGenerator fails with NPE #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

HDDS-1180. TestRandomKeyGenerator fails with NPE #519

wants to merge 1 commit into from

Conversation

@elek
Copy link
Member

@elek elek commented Feb 26, 2019

@elek elek added the ozone label Feb 26, 2019
@hadoop-yetus
Copy link

hadoop-yetus commented Feb 26, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 28 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1006 trunk passed
-1 compile 55 tools in trunk failed.
+1 checkstyle 15 trunk passed
-1 mvnsite 23 tools in trunk failed.
+1 shadedclient 648 branch has no errors when building and testing our client artifacts.
-1 findbugs 22 tools in trunk failed.
+1 javadoc 21 trunk passed
_ Patch Compile Tests _
-1 mvninstall 21 tools in the patch failed.
-1 compile 19 tools in the patch failed.
-1 javac 19 tools in the patch failed.
+1 checkstyle 11 the patch passed
-1 mvnsite 19 tools in the patch failed.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 704 patch has no errors when building and testing our client artifacts.
-1 findbugs 23 tools in the patch failed.
+1 javadoc 19 the patch passed
_ Other Tests _
-1 unit 24 tools in the patch failed.
+1 asflicense 29 The patch does not generate ASF License warnings.
2779
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-519/1/artifact/out/Dockerfile
GITHUB PR #519
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 0009452f6cdc 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 59ba355
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-519/1/artifact/out/branch-compile-hadoop-ozone_tools.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-519/1/artifact/out/branch-mvnsite-hadoop-ozone_tools.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-519/1/artifact/out/branch-findbugs-hadoop-ozone_tools.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-519/1/artifact/out/patch-mvninstall-hadoop-ozone_tools.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-519/1/artifact/out/patch-compile-hadoop-ozone_tools.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-519/1/artifact/out/patch-compile-hadoop-ozone_tools.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-519/1/artifact/out/patch-mvnsite-hadoop-ozone_tools.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-519/1/artifact/out/patch-findbugs-hadoop-ozone_tools.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-519/1/artifact/out/patch-unit-hadoop-ozone_tools.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-519/1/testReport/
Max. process+thread count 411 (vs. ulimit of 5500)
modules C: hadoop-ozone/tools U: hadoop-ozone/tools
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-519/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@elek
Copy link
Member Author

elek commented Feb 26, 2019

See the ci/ozone/unit: Only one unit tests are failed: TestRandomKeyGenerator.ratisTest3 which is not a NPE any more.

@bharatviswa504
Copy link
Contributor

bharatviswa504 commented Feb 27, 2019

+1 LGTM.

@bharatviswa504
Copy link
Contributor

bharatviswa504 commented Feb 27, 2019

This has been already fixed and committed by HDDS-1174.

shanthoosh added a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@shanthoosh @jagadish-v0
SAMZA-1712: Tear down ZookeeperServer connections in ZkClient on inte…
72ad752 
…rrupts.

**Problem:**

If a thread executing zkClient.close is interrupted, currently we swallow the ZkInterruptedException and proceed without closing the zookeeper connection.

This leads to ephemeral nodes of StreamProcessor lurking around in zookeeper after StreamProcessor shutdown.

Users had to wait till zookeeper server session timeout for the ephemeral nodes to get deleted.

**Change:**

Retry once on InterruptedException when closing the zkClient.

Misc changes:
* Remove unnecessary null checks.
* Remove unnecessary typecasts.

Author: Shanthoosh Venkataraman <santhoshvenkat1988@gmail.com>

Reviewers: Jagadish <jagadish@apache.org>

Closes apache#519 from shanthoosh/handle_interrupted_exception_in_zkclient_close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ozone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elek @hadoop-yetus @bharatviswa504