YARN-11388: Prevent resource leaks in TestClientRMService.

[cnauroth]

Description of PR

• Guarantee servers always get closed, even if a test throws an exception.
• Keep the generated excludeFile in a random test directory.
• Clean up most style and whitespace warnings.

How was this patch tested?

Ran unit tests locally.

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[hadoop-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 19s		trunk passed
+1 💚	compile	1m 15s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	1m 13s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 3s		trunk passed
+1 💚	mvnsite	1m 12s		trunk passed
+1 💚	javadoc	1m 5s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 59s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 25s		trunk passed
+1 💚	shadedclient	21m 58s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 59s		the patch passed
+1 💚	compile	0m 59s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 59s		the patch passed
+1 💚	compile	0m 58s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 58s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 48s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 10 unchanged - 16 fixed = 12 total (was 26)
+1 💚	mvnsite	0m 59s		the patch passed
+1 💚	javadoc	0m 42s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 39s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 0s		the patch passed
+1 💚	shadedclient	21m 27s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	99m 10s		hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 44s		The patch does not generate ASF License warnings.
		201m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5187/1/artifact/out/Dockerfile
GITHUB PR	#5187
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ba31b6c05a6f 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 0d7d415
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5187/1/testReport/
Max. process+thread count	995 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5187/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[cnauroth]

@szilard-nemeth and @slfan1989 , I noticed you have been pretty active in the ResourceManager tests. Are you available to review this? Thank you.

[slfan1989]

@szilard-nemeth and @slfan1989 , I noticed you have been pretty active in the ResourceManager tests. Are you available to review this? Thank you.

@cnauroth Thank you so much for inviting me to look at the code, I took a quick look, LGTM, I'll take a closer look at it again later.

[cnauroth]

@szilard-nemeth and @slfan1989 , I noticed you have been pretty active in the ResourceManager tests. Are you available to review this? Thank you.

@cnauroth Thank you so much for inviting me to look at the code, I took a quick look, LGTM, I'll take a closer look at it again later.

Thank you, @slfan1989 !

[slfan1989]

@cnauroth Thank you very much for your contribution! LGTM.

[cnauroth]

I have merged this to trunk, branch-3.3 and branch-3.2 (after resolving some minor merge conflicts). @slfan1989 , thank you for your review!