HDFS-16858. Dynamically adjust max slow disks to exclude. #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slfan1989
reviewed
Dec 1, 2022
| import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_MAX_NUM_BLOCKS_TO_LOG_KEY; | ||
| import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_METRICS_LOGGER_PERIOD_SECONDS_DEFAULT; | ||
| import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_METRICS_LOGGER_PERIOD_SECONDS_KEY; | ||
| import static org.apache.hadoop.hdfs.DFSConfigKeys.*; |
slfan1989
reviewed
Dec 1, 2022
| import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_MIN_OUTLIER_DETECTION_DISKS_KEY; | ||
| import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_OUTLIERS_REPORT_INTERVAL_KEY; | ||
| import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_SLOWDISK_LOW_THRESHOLD_MS_KEY; | ||
| import static org.apache.hadoop.hdfs.DFSConfigKeys.*; |
slfan1989
reviewed
Dec 1, 2022
| assertEquals(String.format("expect %s is not configured", | ||
| DFS_DATANODE_MIN_OUTLIER_DETECTION_DISKS_KEY), null, | ||
| dn.getConf().get(DFS_DATANODE_MIN_OUTLIER_DETECTION_DISKS_KEY)); | ||
| assertEquals(String.format("expect %s is not configured", | ||
| DFS_DATANODE_SLOWDISK_LOW_THRESHOLD_MS_KEY), null, | ||
| dn.getConf().get(DFS_DATANODE_SLOWDISK_LOW_THRESHOLD_MS_KEY)); | ||
| assertEquals(String.format("expect %s is not configured", | ||
| DFS_DATANODE_MAX_SLOWDISKS_TO_EXCLUDE_KEY), null, |
|
@dingshun3016 Thank you very much for your contribution, but we need to fix some checkstyle issues. |
|
@slfan1989 Thank you for your review，I have fixed it. |
cnauroth
approved these changes
Dec 1, 2022
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@cnauroth @slfan1989 could you please merge this PR? Thanks. |
@dingshun3016 Can we rebase again? Let's see the compilation result of jenkins. |
|
💔 -1 overall
This message was automatically generated. |
|
dingshun3016
force-pushed
the
HDFS-16858
branch
from
bfb87c4
to
684104b
Compare
|
💔 -1 overall
This message was automatically generated. |
tomscut
reviewed
Dec 5, 2022
|
💔 -1 overall
This message was automatically generated. |
|
slfan1989
approved these changes
Dec 7, 2022
|
|
|
💔 -1 overall
This message was automatically generated. |
|
Thanks @dingshun3016 for your contribution! Thanks @cnauroth and @slfan1989 for your review! |
slfan1989
pushed a commit
to slfan1989/hadoop
that referenced
this pull request
Dec 20, 2022
Reviewed-by: Chris Nauroth <cnauroth@apache.org> Reviewed-by: slfan1989 <55643692+slfan1989@users.noreply.github.com> Signed-off-by: Tao Li <tomscut@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: HDFS-16858.
In large clusters, rolling restart datanodes takes long time. We can make slow disks parameters in datanode reconfigurable to facilitate cluster operation and maintenance. Some parameters related to slow disks have been supported in HDFS-16397. Reconfig slow disk parameters for datanode, but I found that there are still some parameters that need