YARN-11350. [Federation] Router Support DelegationToken With ZK.(Old Version) #5111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@goiri Can you help review this pr? Thank you very much! |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Nov 13, 2022
| @@ -129,6 +135,7 @@ | |||
| * |--- RESERVATION | |||
| * | |----- RESERVATION1 | |||
| * | |----- RESERVATION2 | |||
| * |--- | |||
There was a problem hiding this comment.
Thank you very much for your help reviewing the code, I will fix it.
| @@ -1002,7 +1053,9 @@ public RouterRMTokenResponse removeStoredToken(RouterRMTokenRequest request) | |||
| @Override | |||
| public RouterRMTokenResponse getTokenByRouterStoreToken(RouterRMTokenRequest request) | |||
| throws YarnException, IOException { | |||
| request.getRouterStoreToken().getTokenIdentifier(); | |||
| throw new NotImplementedException("Code is not implemented"); | |||
There was a problem hiding this comment.
This part of the code has been completed, I will confirm my submission record again.
| } else { | ||
| nodeName += String.format("%04d", rmDTSequenceNumber); | ||
| put(nodeCreatePath, routerStoreToken.toByteArray(), false); |
There was a problem hiding this comment.
put(nodeCreatePath, routerStoreToken.toByteArray(), isUpdate);
slfan1989
changed the title
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
We have submitted a new pr (#5131), this pr will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: YARN-11350. [Federation] Router Support DelegationToken With ZK.
YARN Router needs to support DelegationToken. In the process of implementing this feature, refer to
RMDelegationTokenSecretManager, HDFSRBF#ZKDelegationTokenSecretManager.There are a few things to keep in mind to implement this feature:
1.How to store and query
masterkey?2.How to store and query
DelegationToken?3.How to store and query
SequenceNum?For
question 1andquestion 2, we can directly refer toRMDelegationTokenSecretManagerto serialize the data and store it in ZK.For
question 3, we need to consider multiple routers sharingsequenceNum, and we need to ensure that the self-increment ofsequenceNumcan be shared among multiple routers. At this point we will use curator's SharedCount to implement this function.For the introduction of SharedCount, we can refer to the following articles
https://curator.apache.org/curator-recipes/shared-counter.html.