Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17563. Upgrade BouncyCastle to 1.68 (#3980) #5015

Conversation

steveloughran
Copy link
Contributor

Contributed by PJ Fanning

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@steveloughran steveloughran force-pushed the upgrade/HADOOP-17563-bouncy-castle-branch-3.3 branch 2 times, most recently from 57eb33e to 4a8d45e Compare October 13, 2022 16:29
Addresses CVE-2020-15522 and CVE-2020-26939.

This can break builds with older maven shade plugins or
other code using asm.jar which is not aware of recent java bytecodes
and/or multirelease JARs.

Contributed by PJ Fanning

Change-Id: Iea08fbd03acd2ce5b61164b1f9c92a0e61207a6b
@steveloughran steveloughran force-pushed the upgrade/HADOOP-17563-bouncy-castle-branch-3.3 branch from 4a8d45e to 98c7a56 Compare October 14, 2022 11:00
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 15m 16s Maven dependency ordering for branch
+1 💚 mvninstall 26m 58s branch-3.3 passed
+1 💚 compile 19m 6s branch-3.3 passed
+1 💚 mvnsite 21m 20s branch-3.3 passed
+1 💚 javadoc 7m 6s branch-3.3 passed
+1 💚 shadedclient 32m 11s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 31s Maven dependency ordering for patch
+1 💚 mvninstall 24m 53s the patch passed
+1 💚 compile 18m 33s the patch passed
+1 💚 javac 18m 33s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 21m 3s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 6m 56s the patch passed
+1 💚 shadedclient 32m 54s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 707m 41s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 2m 0s The patch does not generate ASF License warnings.
926m 19s
Reason Tests
Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
hadoop.hdfs.TestFileCreation
hadoop.hdfs.tools.TestDFSAdmin
hadoop.yarn.sls.appmaster.TestAMSimulator
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5015/4/artifact/out/Dockerfile
GITHUB PR #5015
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux 96ba0915b1ba 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 98c7a56
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5015/4/testReport/
Max. process+thread count 2718 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5015/4/console
versions git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor Author

flaky tests; ignoring

@steveloughran steveloughran merged commit cd856b7 into apache:branch-3.3 Oct 15, 2022
asfgit pushed a commit that referenced this pull request Oct 17, 2022
Addresses CVE-2020-15522 and CVE-2020-26939.

This can break builds with older maven shade plugins or
other code using asm.jar which is not aware of recent java bytecodes
and/or multi-release JARs. fix: use a later version of asm.jar

Contributed by PJ Fanning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants