-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11315. [Federation] YARN Federation Router Supports Cross-Origin. #4934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎊 +1 overall
This message was automatically generated. |
@goiri Can you help review this pr? Thank you very much! |
|
||
/** | ||
* Tests {@link Router}. | ||
*/ | ||
public class TestRouter { | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion, I will fix it.
@@ -50,5 +50,6 @@ public void setup() { | |||
route("/apps", RouterController.class, "apps"); | |||
route("/nodes", RouterController.class, "nodes"); | |||
route("/federation", RouterController.class, "federation"); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix it.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@goiri Please help to review the code again, thank you very much! |
🎊 +1 overall
This message was automatically generated. |
@goiri Can you help merge this pr into trunk branch? Thank you so much! I will follow up on YARN-11329. Refactor Router#startWepApp#setupSecurityAndFilters. |
🎊 +1 overall
This message was automatically generated. |
@goiri Thank you very much for helping to review the code! |
JIRA: YARN-11315. [Federation] YARN Federation Router Supports Cross-Origin.
1.The Rest interface of Router should support Cross-Origin like RM and NM.
2.The Yarn-UI2 module requires the Router to support Cross-Origin.