-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11287. Fix NoClassDefFoundError after YARN-10793(#4603) #4828
Conversation
…e/LauncherFactory After YARN-10793
@ashutoshcipher @aajisaka I found that after YARN-10793 Upgrade Junit from 4 to 5 in hadoop-yarn-server-applicationhistoryservice, Junit Test under the entire module of Yarn will have an exception, java.lang.NoClassDefFoundError: org/junit/platform/launcher/core/LauncherFactory : org.junit.platform.launcher.core.LauncherFactory. -1 ❌ unit 36m 10s hadoop-yarn in the patch failed. I import a dependency in the hadoop-yarn-server-applicationhistoryservice module. The compilation report is as follows I think when upgrading junit test 4 to 5, we should consider global unit tests. I confirmed that this modification is possible. +1 💚 | unit | 237m 49s | | hadoop-yarn in the patch passed. Can you help review the code, thank you very much! |
💔 -1 overall
This message was automatically generated. |
+1 for the change. Thank you @slfan1989
Qbt job daily runs global unit tests, but I couldn't find any issue https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/967/artifact/out/ Probably qbt didn't run test on hadoop-yarn because the module itself has no Java tests. |
@aajisaka @ashutoshcipher Thank you very much for helping to review the code! |
…e/LauncherFactory after YARN-10793 (apache#4828) Co-authored-by: slfan1989 <louj1988@@> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
JIRA: YARN-11287. Fix NoClassDefFoundError: org/junit/platform/launcher/core/LauncherFactory After YARN-10793(#4603).
After executing the yarn-project global unit test, I found the following error: