Skip to content

fix some alerts raised by LGTM #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix some alerts raised by LGTM #474

wants to merge 1 commit into from

Conversation

malcolmtaylor
Copy link
Contributor

LGTM has raised some alerts after analysing Hadoop (https://lgtm.com/projects/g/apache/hadoop/alerts/?mode=tree).
This pull request is to fix some of the more straightforward ones. Specifically,

  • ArrayIndexOutOfBounds in KerberosName
  • Contradictory type checks in GenericExceptionHandler
    -Missing format argument in RegistrySecurity, HttpFSExceptionProvider, DatasetVolumeChecker and ServiceClient

(disclosure: I work for Semmle, the company behind LGTM).

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 12 #474 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
GITHUB PR #474
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-474/1/console
versions git=2.7.4
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 23 Maven dependency ordering for branch
+1 mvninstall 1089 trunk passed
+1 compile 1117 trunk passed
+1 checkstyle 135 trunk passed
+1 mvnsite 144 trunk passed
+1 shadedclient 970 branch has no errors when building and testing our client artifacts.
+1 javadoc 120 trunk passed
0 spotbugs 107 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 231 trunk passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 99 the patch passed
+1 compile 1043 the patch passed
+1 javac 1043 the patch passed
-0 checkstyle 130 root: The patch generated 1 new + 123 unchanged - 1 fixed = 124 total (was 124)
+1 mvnsite 146 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 631 patch has no errors when building and testing our client artifacts.
+1 javadoc 119 the patch passed
+1 findbugs 274 the patch passed
_ Other Tests _
+1 unit 187 hadoop-auth in the patch passed.
+1 unit 61 hadoop-registry in the patch passed.
+1 unit 285 hadoop-hdfs-httpfs in the patch passed.
+1 unit 232 hadoop-yarn-common in the patch passed.
+1 asflicense 41 The patch does not generate ASF License warnings.
7149
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-474/2/artifact/out/Dockerfile
GITHUB PR #474
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 64e16223de95 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c7c7a88
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-474/2/artifact/out/diff-checkstyle-root.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-474/2/testReport/
Max. process+thread count 619 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-474/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 69 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 27 Maven dependency ordering for branch
+1 mvninstall 1269 trunk passed
+1 compile 1271 trunk passed
+1 checkstyle 143 trunk passed
+1 mvnsite 159 trunk passed
+1 shadedclient 1022 branch has no errors when building and testing our client artifacts.
+1 javadoc 129 trunk passed
0 spotbugs 134 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 284 trunk passed
_ Patch Compile Tests _
0 mvndep 28 Maven dependency ordering for patch
+1 mvninstall 115 the patch passed
+1 compile 1149 the patch passed
+1 javac 1149 the patch passed
-0 checkstyle 149 root: The patch generated 1 new + 123 unchanged - 1 fixed = 124 total (was 124)
+1 mvnsite 157 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 676 patch has no errors when building and testing our client artifacts.
+1 javadoc 144 the patch passed
+1 findbugs 314 the patch passed
_ Other Tests _
+1 unit 218 hadoop-auth in the patch passed.
+1 unit 81 hadoop-registry in the patch passed.
+1 unit 333 hadoop-hdfs-httpfs in the patch passed.
+1 unit 246 hadoop-yarn-common in the patch passed.
+1 asflicense 41 The patch does not generate ASF License warnings.
8038
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-474/3/artifact/out/Dockerfile
GITHUB PR #474
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 9758ef6e3e6c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c2d00c8
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-474/3/artifact/out/diff-checkstyle-root.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-474/3/testReport/
Max. process+thread count 616 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-474/3/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 23 Maven dependency ordering for branch
+1 mvninstall 1038 trunk passed
+1 compile 1283 trunk passed
+1 checkstyle 130 trunk passed
+1 mvnsite 139 trunk passed
+1 shadedclient 963 branch has no errors when building and testing our client artifacts.
+1 javadoc 128 trunk passed
0 spotbugs 104 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 224 trunk passed
_ Patch Compile Tests _
0 mvndep 26 Maven dependency ordering for patch
+1 mvninstall 94 the patch passed
+1 compile 1015 the patch passed
+1 javac 1015 the patch passed
-0 checkstyle 131 root: The patch generated 1 new + 123 unchanged - 1 fixed = 124 total (was 124)
+1 mvnsite 139 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 633 patch has no errors when building and testing our client artifacts.
+1 javadoc 122 the patch passed
+1 findbugs 257 the patch passed
_ Other Tests _
+1 unit 189 hadoop-auth in the patch passed.
-1 unit 54 hadoop-registry in the patch failed.
-1 unit 268 hadoop-hdfs-httpfs in the patch failed.
+1 unit 223 hadoop-yarn-common in the patch passed.
+1 asflicense 42 The patch does not generate ASF License warnings.
7182
Reason Tests
Failed junit tests hadoop.registry.operations.TestRegistryOperations
hadoop.fs.http.client.TestHttpFSWithHttpFSFileSystem
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-474/4/artifact/out/Dockerfile
GITHUB PR #474
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux bb13399ad3ba 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / b0131bc
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-474/4/artifact/out/diff-checkstyle-root.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-474/4/artifact/out/patch-unit-hadoop-common-project_hadoop-registry.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-474/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-474/4/testReport/
Max. process+thread count 626 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-474/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 83 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 22 Maven dependency ordering for branch
+1 mvninstall 1181 trunk passed
+1 compile 1076 trunk passed
+1 checkstyle 153 trunk passed
+1 mvnsite 153 trunk passed
+1 shadedclient 1100 branch has no errors when building and testing our client artifacts.
+1 javadoc 135 trunk passed
0 spotbugs 116 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 247 trunk passed
_ Patch Compile Tests _
0 mvndep 25 Maven dependency ordering for patch
+1 mvninstall 103 the patch passed
+1 compile 1033 the patch passed
+1 javac 1033 the patch passed
-0 checkstyle 156 root: The patch generated 1 new + 123 unchanged - 1 fixed = 124 total (was 124)
+1 mvnsite 162 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 748 patch has no errors when building and testing our client artifacts.
+1 javadoc 137 the patch passed
+1 findbugs 291 the patch passed
_ Other Tests _
+1 unit 210 hadoop-auth in the patch passed.
+1 unit 63 hadoop-registry in the patch passed.
+1 unit 282 hadoop-hdfs-httpfs in the patch passed.
+1 unit 233 hadoop-yarn-common in the patch passed.
+1 asflicense 54 The patch does not generate ASF License warnings.
7662
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-474/5/artifact/out/Dockerfile
GITHUB PR #474
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux ddc0ab9672ca 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e356e4f
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-474/5/artifact/out/diff-checkstyle-root.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-474/5/testReport/
Max. process+thread count 607 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-474/5/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 46 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 23 Maven dependency ordering for branch
+1 mvninstall 1115 trunk passed
+1 compile 1076 trunk passed
+1 checkstyle 137 trunk passed
+1 mvnsite 141 trunk passed
+1 shadedclient 1016 branch has no errors when building and testing our client artifacts.
+1 javadoc 112 trunk passed
0 spotbugs 98 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 210 trunk passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 99 the patch passed
+1 compile 1100 the patch passed
+1 javac 1100 the patch passed
-0 checkstyle 144 root: The patch generated 1 new + 124 unchanged - 1 fixed = 125 total (was 125)
+1 mvnsite 130 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 632 patch has no errors when building and testing our client artifacts.
+1 javadoc 132 the patch passed
+1 findbugs 257 the patch passed
_ Other Tests _
+1 unit 183 hadoop-auth in the patch passed.
+1 unit 57 hadoop-registry in the patch passed.
+1 unit 260 hadoop-hdfs-httpfs in the patch passed.
+1 unit 218 hadoop-yarn-common in the patch passed.
+1 asflicense 45 The patch does not generate ASF License warnings.
7166
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-474/6/artifact/out/Dockerfile
GITHUB PR #474
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux dc84cf67c6be 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 094d736
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-474/6/artifact/out/diff-checkstyle-root.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-474/6/testReport/
Max. process+thread count 624 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-474/6/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 61 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 20 Maven dependency ordering for branch
+1 mvninstall 1058 trunk passed
+1 compile 1071 trunk passed
+1 checkstyle 138 trunk passed
+1 mvnsite 157 trunk passed
+1 shadedclient 1001 branch has no errors when building and testing our client artifacts.
+1 javadoc 113 trunk passed
0 spotbugs 98 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 207 trunk passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 98 the patch passed
+1 compile 1145 the patch passed
+1 javac 1145 the patch passed
-0 checkstyle 141 root: The patch generated 1 new + 123 unchanged - 1 fixed = 124 total (was 124)
+1 mvnsite 139 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 618 patch has no errors when building and testing our client artifacts.
+1 javadoc 122 the patch passed
+1 findbugs 257 the patch passed
_ Other Tests _
+1 unit 203 hadoop-auth in the patch passed.
+1 unit 61 hadoop-registry in the patch passed.
-1 unit 294 hadoop-hdfs-httpfs in the patch failed.
+1 unit 229 hadoop-yarn-common in the patch passed.
+1 asflicense 41 The patch does not generate ASF License warnings.
7186
Reason Tests
Failed junit tests hadoop.fs.http.server.TestHttpFSServer
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-474/7/artifact/out/Dockerfile
GITHUB PR #474
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 791dd235f301 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 69ddb36
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-474/7/artifact/out/diff-checkstyle-root.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-474/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-474/7/testReport/
Max. process+thread count 615 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-474/7/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 61 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 25 Maven dependency ordering for branch
+1 mvninstall 1171 trunk passed
+1 compile 1095 trunk passed
+1 checkstyle 148 trunk passed
+1 mvnsite 168 trunk passed
+1 shadedclient 1055 branch has no errors when building and testing our client artifacts.
+1 javadoc 154 trunk passed
0 spotbugs 112 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 256 trunk passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 114 the patch passed
+1 compile 972 the patch passed
+1 javac 972 the patch passed
-0 checkstyle 142 root: The patch generated 1 new + 124 unchanged - 1 fixed = 125 total (was 125)
+1 mvnsite 174 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 684 patch has no errors when building and testing our client artifacts.
+1 javadoc 162 the patch passed
+1 findbugs 289 the patch passed
_ Other Tests _
+1 unit 199 hadoop-auth in the patch passed.
+1 unit 71 hadoop-registry in the patch passed.
+1 unit 307 hadoop-hdfs-httpfs in the patch passed.
+1 unit 239 hadoop-yarn-common in the patch passed.
+1 asflicense 50 The patch does not generate ASF License warnings.
7590
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-474/8/artifact/out/Dockerfile
GITHUB PR #474
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 5f2df5267072 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3329257
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-474/8/artifact/out/diff-checkstyle-root.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-474/8/testReport/
Max. process+thread count 624 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-474/8/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 35 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 22 Maven dependency ordering for branch
+1 mvninstall 1167 trunk passed
+1 compile 1064 trunk passed
+1 checkstyle 152 trunk passed
+1 mvnsite 160 trunk passed
+1 shadedclient 1103 branch has no errors when building and testing our client artifacts.
+1 javadoc 137 trunk passed
0 spotbugs 121 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 250 trunk passed
_ Patch Compile Tests _
0 mvndep 24 Maven dependency ordering for patch
+1 mvninstall 107 the patch passed
+1 compile 1030 the patch passed
+1 javac 1030 the patch passed
-0 checkstyle 158 root: The patch generated 1 new + 123 unchanged - 1 fixed = 124 total (was 124)
+1 mvnsite 151 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 748 patch has no errors when building and testing our client artifacts.
+1 javadoc 140 the patch passed
+1 findbugs 307 the patch passed
_ Other Tests _
+1 unit 200 hadoop-auth in the patch passed.
+1 unit 62 hadoop-registry in the patch passed.
+1 unit 336 hadoop-hdfs-httpfs in the patch passed.
+1 unit 238 hadoop-yarn-common in the patch passed.
+1 asflicense 47 The patch does not generate ASF License warnings.
7643
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-474/9/artifact/out/Dockerfile
GITHUB PR #474
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 92ba678b92a3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 915cbc9
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-474/9/artifact/out/diff-checkstyle-root.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-474/9/testReport/
Max. process+thread count 599 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-474/9/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member

Hi @1m2c3t4
Would you create an issue in ASF JIRA before creating a pull request?
Contributor guide: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@malcolmtaylor
Copy link
Contributor Author

@aajisaka I have now created HADOOP-16556. I'll close this PR and replace it with #1428

shanthoosh added a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@shanthoosh @jagadish-v0
SAMZA-1656: EventHubSystemAdmin does not fetch metadata for valid str…
71dba52 
…eams.

Currently successive invocation of EventHubSystemAdmin.getSystemStreamMetadata with the same stream collection returns empty results.

This is an implementation bug, where the streams requested as a part of prior invocations of EventHubSystemAdmin.getSystemStreamMetadata are ignored(due to stale caching).

This bug causes the JobModel generation phase to fail and kills the StreamProcessor.

Author: Shanthoosh Venkataraman <svenkataraman@linkedin.com>

Reviewers: Jagadish <jagadish@apache.org>, Srini P<spunuru@linkedin.com>

Closes apache#474 from shanthoosh/EventHubSystemAdminBug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malcolmtaylor @hadoop-yetus @aajisaka