HADOOP-18402. S3A committer NPE in spark job abort #4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobId.toString() to only be called when the ID isn't null. this doesn't surface in MR, but spark seems to manage it Change-Id: I06692ef30a4af510c660d7222292932a8d4b5147
|
tests in progress |
|
tested, s3 london -Dscale |
|
this is not anything anyone has shipped yet |
|
💔 -1 overall
This message was automatically generated. |
|
Thank you for pinging me, @steveloughran . |
asfgit
pushed a commit
that referenced
this pull request
Aug 15, 2022
(managed to commit through the github ui before I'd got the message done) This reverts commit ad83e95.
asfgit
pushed a commit
that referenced
this pull request
Aug 15, 2022
JobID.toString() and TaskID.toString() to only be called when the IDs are not null. This doesn't surface in MapReduce, but Spark SQL can trigger in job abort, where it may invok abortJob() with an incomplete TaskContext. This patch MUST be applied to branches containing HADOOP-17833. "Improve Magic Committer Performance." Contributed by Steve Loughran.
asfgit
pushed a commit
that referenced
this pull request
Aug 15, 2022
JobID.toString() and TaskID.toString() to only be called when the IDs are not null. This doesn't surface in MapReduce, but Spark SQL can trigger in job abort, where it may invoke abortJob() with an incomplete TaskContext. This patch MUST be applied to branches containing HADOOP-17833. "Improve Magic Committer Performance." Contributed by Steve Loughran.
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
jobId.toString() to only be called when the ID isn't null. this doesn't surface in MR, but spark seems to manage it Change-Id: I06692ef30a4af510c660d7222292932a8d4b5147
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…)" (managed to commit through the github ui before I'd got the message done) This reverts commit ad83e95.
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
JobID.toString() and TaskID.toString() to only be called when the IDs are not null. This doesn't surface in MapReduce, but Spark SQL can trigger in job abort, where it may invok abortJob() with an incomplete TaskContext. This patch MUST be applied to branches containing HADOOP-17833. "Improve Magic Committer Performance." Contributed by Steve Loughran.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jobId.toString() to only be called when the ID isn't null.
this doesn't surface in MR, but spark seems to manage it
How was this patch tested?
through my downstream runs of spark integration tests
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?