-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAPREDUCE-7403. manifest-committer dynamic partitioning support. #4728
Merged
steveloughran
merged 6 commits into
apache:trunk
from
steveloughran:mr/MAPREDUCE-7403-manifest-committer-partitioning
Aug 24, 2022
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f2ec350
MAPREDUCE-7403. manifest-committer dynamic partitioning support.
steveloughran b259c29
MAPREDUCE-7403. dynamic partitioning -verify stream capabilities pass…
steveloughran 82372d0
MAPREDUCE-7403. document dynamic partition support
steveloughran 25db5da
MAPREDUCE-7403. EOLs
steveloughran 649b902
MAPREDUCE-7403. fix asserts
steveloughran bc9dfc9
MAPREDUCE-7403. fix accidental edit
steveloughran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -61,6 +61,7 @@ | |||||
import org.apache.hadoop.mapreduce.RecordWriter; | ||||||
import org.apache.hadoop.mapreduce.TaskAttemptContext; | ||||||
import org.apache.hadoop.mapreduce.TaskAttemptID; | ||||||
import org.apache.hadoop.mapreduce.lib.output.BindingPathOutputCommitter; | ||||||
import org.apache.hadoop.mapreduce.lib.output.FileOutputFormat; | ||||||
import org.apache.hadoop.mapreduce.lib.output.MapFileOutputFormat; | ||||||
import org.apache.hadoop.mapreduce.lib.output.PathOutputCommitterFactory; | ||||||
|
@@ -1549,6 +1550,21 @@ public void testOutputFormatIntegration() throws Throwable { | |||||
ManifestCommitter committer = (ManifestCommitter) | ||||||
outputFormat.getOutputCommitter(tContext); | ||||||
|
||||||
// check path capabilities directly | ||||||
Assertions.assertThat(committer.hasCapability( | ||||||
ManifestCommitterConstants.CAPABILITY_DYNAMIC_PARTITIONING)) | ||||||
.describedAs("dynamic partitioning capability in committer %s", | ||||||
committer); | ||||||
// and through a binding committer -passthrough is critical | ||||||
// for the spark binding. | ||||||
BindingPathOutputCommitter bindingCommitter = | ||||||
new BindingPathOutputCommitter(outputDir, tContext); | ||||||
Assertions.assertThat(bindingCommitter.hasCapability( | ||||||
ManifestCommitterConstants.CAPABILITY_DYNAMIC_PARTITIONING)) | ||||||
.describedAs("dynamic partitioning capability in committer %s", | ||||||
bindingCommitter); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
|
||||||
// setup | ||||||
JobData jobData = new JobData(job, jContext, tContext, committer); | ||||||
setupJob(jobData); | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did i just get my asserts wrong. that was bad. thanks!