HDFS-16724. RBF should support get the information about ancestor mount points #4719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Aug 9, 2022
| import java.io.IOException; | ||
|
|
||
| /** | ||
| * Exception when no location found. |
There was a problem hiding this comment.
Is there a better name that reflects this is from the mount point perspective?
Extend the javadoc a little anyway.
| @@ -956,7 +959,7 @@ public HdfsFileStatus getFileInfo(String src) throws IOException { | |||
| if (children != null && !children.isEmpty()) { | |||
| Map<String, Long> dates = getMountPointDates(src); | |||
| long date = 0; | |||
| if (dates != null && dates.containsKey(src)) { | |||
| if (dates.containsKey(src)) { | |||
There was a problem hiding this comment.
I would leave the null check; it is good practice.
There was a problem hiding this comment.
Modified it since getMountPointDates always return a not null response. I will roll back this modification.
...-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java
Show resolved
Hide resolved
| @@ -1731,7 +1731,7 @@ protected List<RemoteLocation> getLocationsForPath(String path, | |||
| final PathLocation location = | |||
| this.subclusterResolver.getDestinationForPath(path); | |||
| if (location == null) { | |||
| throw new IOException("Cannot find locations for " + path + " in " + | |||
| throw new NoLocationException("Cannot find locations for " + path + " in " + | |||
There was a problem hiding this comment.
As we have a dedicated exception, we can pass the path and class parameters and build the message in NoLocationException
| public void clearMountTable() throws IOException { | ||
| RouterClient client = routerContext.getAdminClient(); | ||
| MountTableManager mountTableManager = client.getMountTableManager(); | ||
| GetMountTableEntriesRequest req1 = |
| MountTableManager mountTableManager = client.getMountTableManager(); | ||
| AddMountTableEntryRequest addRequest = | ||
| AddMountTableEntryRequest.newInstance(entry); | ||
| AddMountTableEntryResponse addResponse = |
| try { | ||
| routerProtocol.getFileInfo("/testdir2"); | ||
| fail(); | ||
| } catch (IOException ioe) { |
...-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Master, ping. Thanks |
goiri
approved these changes
Aug 15, 2022
|
@goiri Master, can help me merge this patch into trunk? Then I will rebase HDFS-16728 and HDFS-16734 on the latest trunk. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Suppose RBF cluster have 2 nameservices and to mount point as below:
Suppose we disable default nameservice of the RBF cluster. If we try to get the file information of the path /user, RBF will throw one IOException to client due to can not find locations for path /user.
But as this case, RBF should should return one valid response to client, because /user has two sub mount point ns1 and ns2.