Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDFS-4043. Namenode Kerberos Login does not use proper hostname for host qualified hdfs principal name. #4693

Merged
merged 8 commits into from
Aug 17, 2022

Commits on Aug 12, 2022

  1. HDFS-4043. Namenode Kerberos Login does not use proper hostname for h…

    …ost qualified hdfs principal name.
    
    Perform a DNS reverse name lookup when getCanonicalHost() returns the IP address as a string.
    Steve Vaughan Jr committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    857096a View commit details
    Browse the repository at this point in the history
  2. Add the unit test and license information

    Steve Vaughan Jr committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    555f0ce View commit details
    Browse the repository at this point in the history
  3. Update unit test to be more portable

    Since the core of the problem relates to DNS interactions with private fields inside of Java language classes, this test can only verify that externally a request for a canonical host name works.
    Steve Vaughan Jr committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    11a3bac View commit details
    Browse the repository at this point in the history
  4. Add audience and stability annotations

    Steve Vaughan Jr committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    9507a5e View commit details
    Browse the repository at this point in the history
  5. Switch to existing DomainNameResolver framework

    Instead of introducing a new utility class (i.e. InetAddressUtils) switch to using the existing pluggable framework for DomainNameResolver.
    
    Update default implementation DNSDomainNameResolver to protected against returning the IP address as a string from a cached value.
    Steve Vaughan Jr committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    d14eeba View commit details
    Browse the repository at this point in the history
  6. Log the address that which didn't return a name

    Steve Vaughan Jr committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    41b9768 View commit details
    Browse the repository at this point in the history
  7. Document the default resolver

    Steve Vaughan Jr committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    e88831b View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Avoid SpotBugs warning

     SpotBugs is concerned that getCanonicalHostName() may return null, although the JavaDocs indicate that it will return the IP address as a String if unable to determine the FQDN.  The only circumstance I can imagine where it would return null is if the IP address is null, which would mean a reverse lookup wouldn't work either.
    Steve Vaughan Jr committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    31572d6 View commit details
    Browse the repository at this point in the history