-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-18330-S3AFileSystem removes Path when calling createS3Client #4572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
get yetus to stop failing the build, then run the integration tests against an s3 bucket, then i will review |
🎊 +1 overall
This message was automatically generated. |
ok, which s3 endpoint did you run the tests against? |
Just ran the tests against us-east-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, one comment about getter/setter names
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ClientFactory.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, merging
…4572) Adds a new parameter object in s3ClientCreationParameters that holds the full s3a path URI Contributed by Ashutosh Pant
…pache#4572) Adds a new parameter object in s3ClientCreationParameters that holds the full s3a path URI Contributed by Ashutosh Pant
Greetings, I was wondering what version of hadoop was this change merged into? Is it in 3.3.4 or will this come out with 3.3.5 release? |
look at the jira; comming in 3.3.5 which will be at release candiate 0 this week https://issues.apache.org/jira/browse/HADOOP-18330 |
Greetings. It looks 3.3.5 still hasnt released even though it has been a month. Looks like the current version is still 3.3.4. Can you give us an exact date of when this will release and do so ASAP? |
The first release candidate is up for testing. Download and test it. This is the only way you can be sure that the actual shipped version does what you need. |
where can I download this "candidate" 3.3.5 version you are talking about? It's nowhere on your website. |
Hi, I would appreciate a response to this question above. Thanks |
we put up RCs for review through our dev lists; if you really want to get involved in pre-release code you should subscribe. here is the announcement. as it warns, I've been on vacation for most of the month, hence my lack of replies. ---------- Forwarded message --------- Mukund and I have put together a release candidate (RC0) for Hadoop 3.3.5. Given the time of year it's a bit unrealistic to run a 5 day vote and expect people to be able to test it thoroughly enough to make this the one we can ship. What we would like is for anyone who can to verify the tarballs, and test the binaries, especially anyone who can try the arm64 binaries. We've got the building of those done and now the build file will incorporate them into the release -but neither of us have actually tested it yet. Maybe I should try it on my pi400 over xmas. The maven artifacts are up on the apache staging repo -they are the ones from x86 build. Building and testing downstream apps will be incredibly helpful. The RC is available at: The git tag is release-3.3.5-RC0, commit 3262495 The maven artifacts are staged at You can find my public key at: Change log Release notes This is off branch-3.3 and is the first big release since 3.3.2. Key changes include
Please try the release and vote on it, even though i don't know what is a good timeline here...i'm actually going on holiday in early jan. Mukund is around and so can drive the process while I'm offline. Assuming we do have another iteration, the RC1 will not be before mid jan for that reason Steve (and mukund) |
Hi there! When can we expect the official release for version 3.3.5. I’m curious what the hold up is. |
one of the big problems is lack of testing of release candidates. it is very frustating to have a release ready and then, during the week of voting on it, not enough people review it. One contribution everyone can make to any of the ASF project is to help validate the release. If you depend on something working, this is an important thing to do. If any bug surfaces now, it wont get fixed for three months at least. |
Description of PR
added new parameter object in s3ClientCreationParameters that returns full s3a path
How was this patch tested?
Tested against the following endpoint -> s3.us-east-1.amazonaws.com
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?