HADOOP-18302. Remove WhiteBox in hadoop-common module. #4457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slfan1989
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@aajisaka Thanks for your suggestion, I will refactor the code. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aajisaka
requested changes
Jul 11, 2022
|
@aajisaka Thank you for helping to review the code, I will fix it as soon as possible. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@aajisaka Please help me to review the code again, thank you very much! |
|
🎊 +1 overall
This message was automatically generated. |
|
@aajisaka Please help me to review the code again, thank you very much! |
aajisaka
requested changes
Aug 30, 2022
| @@ -208,4 +209,8 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable t) { | |||
| LOG.warn("Encountered ", t); | |||
| ctx.channel().close(); | |||
| } | |||
|
|
|||
| public Map<String, PortmapMapping> getMap() { | |||
There was a problem hiding this comment.
Should be package-private and annotated with @VisibleForTesting.
...p-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java
Show resolved
Hide resolved
Comment on lines
205
to
211
| public Graphite getGraphite() { | ||
| return graphite; | ||
| } | ||
|
|
||
| public void setGraphite(Graphite graphite) { | ||
| this.graphite = graphite; | ||
| } |
There was a problem hiding this comment.
Thank you @slfan1989, but I disagree with replicating the class because we have to manually update the test class if there is any change in the original class. Instead, can we make MetricsRecordImpl.java public? Reference:
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@aajisaka Can you help review this pr again? Thank you very much! |
aajisaka
requested changes
Sep 10, 2022
There was a problem hiding this comment.
I'm +1 if the below comment is addressed. Thank you for the update, @slfan1989
...n-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsRecordImpl.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@aajisaka Please help to review the code again, thank you very much! |
|
Merged into trunk. Thank you so much for your contribution, @slfan1989 ! |
|
@aajisaka Thank you very much for helping to review the code! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:HADOOP-18302. Remove WhiteBox in hadoop-common module.
In HADOOP-18277 Jira, the removal of Whitebox was discussed,
aajisaka suggested that the relevant code needs to be refactored to completely remove the Whitebox class, I tried to refactor the code in this pr.