You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: MAPREDUCE-7384. impove import * In MapReduce Project.
Directly using * to reference does not conform to the code specification, adjust it and refer to the specified package.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
38m 22s
trunk passed
+1 💚
compile
0m 28s
trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚
compile
0m 26s
trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚
checkstyle
0m 30s
trunk passed
+1 💚
mvnsite
0m 31s
trunk passed
+1 💚
javadoc
0m 40s
trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚
javadoc
0m 28s
trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚
spotbugs
0m 59s
trunk passed
+1 💚
shadedclient
20m 2s
branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚
mvninstall
0m 23s
the patch passed
+1 💚
compile
0m 21s
the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚
javac
0m 21s
the patch passed
+1 💚
compile
0m 22s
the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚
javac
0m 22s
the patch passed
+1 💚
blanks
0m 0s
The patch has no blanks issues.
+1 💚
checkstyle
0m 16s
hadoop-mapreduce-project/hadoop-mapreduce-examples: The patch generated 0 new + 9 unchanged - 9 fixed = 9 total (was 18)
+1 💚
mvnsite
0m 22s
the patch passed
+1 💚
javadoc
0m 19s
the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚
javadoc
0m 18s
the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚
spotbugs
0m 55s
the patch passed
+1 💚
shadedclient
20m 2s
patch has no errors when building and testing our client artifacts.
-1 to all needless import changes, even if cleanup. import changes are the nightmare of cherrypicks, which is why we so rarely clean them up, even ongoing patches. given a choice between "messy imports in existing code" and "backport hell", i will take the mess.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: MAPREDUCE-7384. impove import * In MapReduce Project.
Directly using * to reference does not conform to the code specification, adjust it and refer to the specified package.