Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAPREDUCE-7384. impove import * In MapReduce Project. #4390

Closed
wants to merge 3 commits into from

Conversation

slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented May 31, 2022

JIRA: MAPREDUCE-7384. impove import * In MapReduce Project.
Directly using * to reference does not conform to the code specification, adjust it and refer to the specified package.

@slfan1989
Copy link
Contributor Author

The improvement work needs to continue for a period of time.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 38m 22s trunk passed
+1 💚 compile 0m 28s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 compile 0m 26s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 0m 30s trunk passed
+1 💚 mvnsite 0m 31s trunk passed
+1 💚 javadoc 0m 40s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 0m 28s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 0m 59s trunk passed
+1 💚 shadedclient 20m 2s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 23s the patch passed
+1 💚 compile 0m 21s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javac 0m 21s the patch passed
+1 💚 compile 0m 22s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 22s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 16s hadoop-mapreduce-project/hadoop-mapreduce-examples: The patch generated 0 new + 9 unchanged - 9 fixed = 9 total (was 18)
+1 💚 mvnsite 0m 22s the patch passed
+1 💚 javadoc 0m 19s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 0m 18s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 0m 55s the patch passed
+1 💚 shadedclient 20m 2s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 45s hadoop-mapreduce-examples in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
89m 25s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4390/1/artifact/out/Dockerfile
GITHUB PR #4390
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux c09b82bd4f16 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 6488b22
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4390/1/testReport/
Max. process+thread count 755 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project/hadoop-mapreduce-examples
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4390/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 42s Maven dependency ordering for branch
+1 💚 mvninstall 27m 15s trunk passed
+1 💚 compile 2m 47s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 compile 2m 21s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 1m 10s trunk passed
+1 💚 mvnsite 2m 35s trunk passed
+1 💚 javadoc 2m 14s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 1m 49s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 4m 31s trunk passed
+1 💚 shadedclient 20m 2s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for patch
+1 💚 mvninstall 1m 50s the patch passed
+1 💚 compile 2m 45s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javac 2m 45s the patch passed
+1 💚 compile 2m 14s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 2m 14s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 50s hadoop-mapreduce-project: The patch generated 0 new + 61 unchanged - 14 fixed = 61 total (was 75)
+1 💚 mvnsite 1m 57s the patch passed
+1 💚 javadoc 1m 28s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 1m 26s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 4m 32s the patch passed
+1 💚 shadedclient 19m 48s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 6m 11s hadoop-mapreduce-client-core in the patch passed.
-1 ❌ unit 1m 3s /patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-common.txt hadoop-mapreduce-client-common in the patch passed.
+1 💚 unit 8m 26s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 0m 46s hadoop-mapreduce-examples in the patch passed.
+1 💚 asflicense 0m 40s The patch does not generate ASF License warnings.
137m 35s
Reason Tests
Failed junit tests hadoop.mapred.TestLocalDistributedCacheManager
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4390/2/artifact/out/Dockerfile
GITHUB PR #4390
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux b52f928dc7f7 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 53e8b3a
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4390/2/testReport/
Max. process+thread count 1572 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4390/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 58s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 15 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 0s Maven dependency ordering for branch
+1 💚 mvninstall 24m 54s trunk passed
+1 💚 compile 2m 57s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 compile 2m 37s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 1m 27s trunk passed
+1 💚 mvnsite 3m 41s trunk passed
+1 💚 javadoc 3m 18s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 3m 3s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 5m 28s trunk passed
+1 💚 shadedclient 20m 31s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 30s Maven dependency ordering for patch
+1 💚 mvninstall 2m 25s the patch passed
+1 💚 compile 2m 41s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javac 2m 41s the patch passed
+1 💚 compile 2m 19s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 2m 19s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 4s hadoop-mapreduce-project: The patch generated 0 new + 188 unchanged - 21 fixed = 188 total (was 209)
+1 💚 mvnsite 2m 37s the patch passed
+1 💚 javadoc 2m 6s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 1m 55s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 4m 55s the patch passed
+1 💚 shadedclient 20m 0s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 6m 38s hadoop-mapreduce-client-core in the patch passed.
-1 ❌ unit 1m 18s /patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-common.txt hadoop-mapreduce-client-common in the patch passed.
+1 💚 unit 8m 45s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 1m 4s hadoop-mapreduce-examples in the patch passed.
+1 💚 asflicense 0m 53s The patch does not generate ASF License warnings.
146m 4s
Reason Tests
Failed junit tests hadoop.mapred.TestLocalDistributedCacheManager
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4390/3/artifact/out/Dockerfile
GITHUB PR #4390
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 2d7d8acff4b9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / e3d2367
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4390/3/testReport/
Max. process+thread count 1561 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4390/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

-1 to all needless import changes, even if cleanup. import changes are the nightmare of cherrypicks, which is why we so rarely clean them up, even ongoing patches. given a choice between "messy imports in existing code" and "backport hell", i will take the mess.

further reading
https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md

@slfan1989
Copy link
Contributor Author

@steveloughran Thanks for your suggestion, I have understood the spec, this pr will be closed, and I will explain it in jira.

@ayushtkn
Copy link
Member

ayushtkn commented Aug 5, 2022

further reading
https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md

This doc is cool, worth having a link in the see also section of Hadoop-How-To-Contribute:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-SeeAlso

@slfan1989
Copy link
Contributor Author

further reading
https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md

This doc is cool, worth having a link in the see also section of Hadoop-How-To-Contribute: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-SeeAlso

@ayushtkn Thank you very much, I will read it carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants