-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18222. Prevent DelegationTokenSecretManagerMetrics from registering multiple times #4266
Conversation
The tests fail, because now the static means the metrics are reused between tests.
|
Updated tests to only check incremental changes in the counters and stats, instead of absolute values |
💔 -1 overall
This message was automatically generated. |
Hi,@hchaverri,@omalley I'm very sorry, but I don't know if you can roll back the changes of HADOOP-18167 first. This change has caused many Junit Tests related to RM to fail. I tried to merge your changes in HADOOP-18222 locally, but Unit Test still reported an error.
|
Hi @hchaverri , |
Hi @hchaverri , I found out that he may have Blocking Java Doc compilation error, I try to solve it. JIRA:https://issues.apache.org/jira/browse/HADOOP-18229 |
I see, thanks for the update. |
There is no problem with your understanding. I thought this patch was not merged because of the Java Doc Error (hadoop-yetus -1), but I carefully read the compilation information, Java Doc Compile Error IN JDK11. |
…ering multiple times Fixes #4266 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>
…ering multiple times Fixes apache#4266 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>
…ering multiple times Fixes apache#4266 Signed-off-by: Owen O'Malley <oomalley@linkedin.com> RB=3362276 BUG=LIHADOOP-65078 G=storage-reviewers R=oomalley,sdzinama A=sdzinama
Description of PR
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?