HDFS-16563. Namenode WebUI prints sensitive information on Token expiry #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hemanthboyina @Hexiaoqiao Can you please review the PR when you get time? |
|
thank you @prasad-acit for the PR, looks the test case failures are related, can you have a look once |
|
@prasad-acit Thanks for involving me here. IMO, the key and sensitive information is DelegationKey/Password for DelegationToken, the output message here does not include this information right? So I don't think it it security issue. Do you mind to more information about this output or stack demo? Thanks. |
|
looks like there are some big assumptions about the nested stack trace coming back. so please restore that change and see what happens if the issue is that toString leaks a secret, it should be fixed at that level, as it is likely to end up in logs. we don't want any output to expose secrets. |
|
Thanks @hemanthboyina @Hexiaoqiao @steveloughran for the quick review & feedback.
Yes, there is no password printed in it. But as per our internal security guidelines displaying the complete Token info is also prohibited. So, suppressed the token from being displayed in the browser.
Logging exception or full stack has no issue in this case. We are trying to avoid the token in the browser and keep the message abstract to the end-user. Here additional information is not necessary which can be avoided in the browser. Failed tests corrected, please review the changes. |
jojochuang
reviewed
Apr 28, 2022
|
Thanks @jojochuang I have added logs with Token Info. |
|
Javadoc issues are not related. |
|
💔 -1 overall
This message was automatically generated. |
|
LGTM; will leave final vote to @jojochuang |
|
Thanks @steveloughran for the review. |
steveloughran
requested changes
May 30, 2022
| err = | ||
| "Token has" + identifier.getRealUser() + "expired, current time: " + Time.formatTime(now) | ||
| + " expected renewal time: " + Time.formatTime(info.getRenewDate()); | ||
| LOG.info(err + ", Token=" + formatTokenId(identifier)); |
There was a problem hiding this comment.
can you use
LOG.info("{}, Token={}", err, formatTokenId(identifier));
| throw new InvalidToken("token " + formatTokenId(identifier) | ||
| + " can't be found in cache"); | ||
| err = "Token for real user: " + identifier.getRealUser() + ", can't be found in cache"; | ||
| LOG.warn(err + ", Token=" + formatTokenId(identifier)); |
There was a problem hiding this comment.
can you use
LOG.warn("{}, Token={}", err, formatTokenId(identifier));
|
💔 -1 overall
This message was automatically generated. |
steveloughran
approved these changes
Jun 3, 2022
asfgit
pushed a commit
that referenced
this pull request
Jun 6, 2022
…ry (#4241) Contributed by Renukaprasad C Change-Id: I5cd2cec1dd79917f810207821b3bdf4fe1a5d24c
|
Thanks @steveloughran |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…ry (apache#4241) Contributed by Renukaprasad C
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?