HDFS-16524. Add configuration to control blocks deletion asynchronous… #4139
+58
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
cxzl25
reviewed
Jul 21, 2022
There was a problem hiding this comment.
According to user feedback, maybe we need this configuration.
cc @Hexiaoqiao
| while (iter.hasNext()) { | ||
| writeLock(); | ||
| try { | ||
| for (int i = 0; i < blockDeletionIncrement && iter.hasNext(); i++) { |
There was a problem hiding this comment.
Removed blockDeletionIncrement in HDFS-16554
There was a problem hiding this comment.
About "blockDeletionIncrement", in my opinion, why we removed it in HDFS-16554 is that we decided to use delete async to replace the previous method, so the "blockDeletionIncrement" won't be used any more. But when we add a switch to control blocks deletion async, we need to save the previous block deletion method, so we still need it.
| @@ -481,6 +481,10 @@ public class DFSConfigKeys extends CommonConfigurationKeys { | |||
| "dfs.namenode.block.deletion.increment"; | |||
| public static final int DFS_NAMENODE_BLOCK_DELETION_INCREMENT_DEFAULT = 1000; | |||
|
|
|||
| /** Block deletion asynchronous. */ | |||
| public static final String DFS_NAMENODE_BLOCK_DELETION_ASYNC_KEY = "dfs.namenode.block.deletion.async"; | |||
| public static final boolean DFS_NAMENODE_BLOCK_DELETION_ASYNC_DEFAULT = false; | |||
|
💔 -1 overall
This message was automatically generated. |
cxzl25
reviewed
Aug 4, 2022
| * a list of blocks that need to be removed from blocksMap | ||
| */ | ||
| void removeBlocks(List<BlockInfo> toDeleteList) { | ||
| if (this.blockDeletionAsync) { |
There was a problem hiding this comment.
The variable blockDeletionAsync doesn't seem to be declared.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
zeekling
reviewed
Jul 10, 2024
| @@ -3403,6 +3407,33 @@ FSPermissionChecker getPermissionChecker() | |||
| return dir.getPermissionChecker(); | |||
| } | |||
|
|
|||
| /** | |||
| * If blockDeletionAsync enables, blocks will be deleted asynchronously. | |||
There was a problem hiding this comment.
use dfs.namenode.block.deletion.async not blockDeletionAsync
| writeLock(); | ||
| try { | ||
| for (int i = 0; i < blockDeletionIncrement && iter.hasNext(); i++) { | ||
| blockManager.removeBlock(iter.next()); |
There was a problem hiding this comment.
Compared with the previous one, the following code is missing:
toRemoveBlocks.clear();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… or synchronous
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?