-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16470. Make HDFS find tool cross platform #4076
Merged
GauthamBanasandra
merged 6 commits into
apache:trunk
from
GauthamBanasandra:find-x-platform
Mar 18, 2022
Merged
HDFS-16470. Make HDFS find tool cross platform #4076
GauthamBanasandra
merged 6 commits into
apache:trunk
from
GauthamBanasandra:find-x-platform
Mar 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Mar 17, 2022
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
* The source files for hdfs_find uses getopt for parsing the command line arguments. getopt is available only on Linux and thus, isn't cross platform. * Thus, we need to replace getopt with boost::program_options to make hdfs_find cross platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The source files for hdfs_find uses getopt for parsing the command line arguments. getopt is available only on Linux and thus, isn't cross platform. We need to replace getopt with boost::program_options to make these tools cross platform.
How was this patch tested?
hdfs_find
I ran hdfs_find with root, it does a traversal of the whole filesystem from the root and displays the same.
I then ran the same command with the -m option which limits the depth of the traversal.
I ran the tool with the -n option, specifying the pattern of the file to find.
$ ./hdfs_find / -n *.txt
I then ran the tool with both the options - limiting the traversal depth and by the pattern to find.
$ ./hdfs_find / -m 2 -n *.txt
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?