-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16495: RBF should prepend the client ip rather than append it. #4054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
hchaverri
reviewed
Mar 11, 2022
...-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
Outdated
Show resolved
Hide resolved
hchaverri
reviewed
Mar 11, 2022
...op-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java
Outdated
Show resolved
Hide resolved
simbadzina
reviewed
Mar 11, 2022
...-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
Outdated
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
ayushtkn
approved these changes
Mar 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
omalley
added a commit
that referenced
this pull request
Mar 14, 2022
Fixes #4054 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Fixes apache#4054 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>
LiuGuH
pushed a commit
to LiuGuH/hadoop
that referenced
this pull request
Mar 26, 2024
Fixes apache#4054 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>
NyteKnight
pushed a commit
to NyteKnight/hadoop
that referenced
this pull request
Jun 25, 2024
Fixes apache#4054 Signed-off-by: Owen O'Malley <oomalley@linkedin.com> RB=3230199 BUG=LIHADOOP-64054 G=storage-reviewers R=hchaverr,sdzinama A=sdzinama
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Makes RBF prepends the client ip & port to the caller context and removes previous values. This avoids a couple problems:
How was this patch tested?
The relevant unit tests were fixed and run.