Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-18114. Documentation Correction #3949

Merged
merged 1 commit into from
Feb 9, 2022
Merged

HADOOP-18114. Documentation Correction #3949

merged 1 commit into from
Feb 9, 2022

Conversation

KraFusion
Copy link
Contributor

Changed reference of s.s3a.assumed.role.credentials.provider to fs.s3a.assumed.role.credentials.provider

@KraFusion
Documentation correction
bbd42dd 
changed reference of s.s3a.assumed.role.credentials.provider to fs.s3a.assumed.role.credentials.provider
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 46s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 5s trunk passed
+1 💚 mvnsite 0m 47s trunk passed
+1 💚 shadedclient 53m 29s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 35s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 36s the patch passed
+1 💚 shadedclient 19m 56s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
79m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3949/1/artifact/out/Dockerfile
GITHUB PR #3949
Optional Tests dupname asflicense mvnsite codespell markdownlint
uname Linux cc73bbfd6344 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / bbd42dd
Max. process+thread count 692 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3949/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ayushtkn
ayushtkn reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, the change looks correct to me.
But you need to create a Hadoop-Common jira
eg.
https://issues.apache.org/jira/browse/HADOOP-17198

Can go through:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@KraFusion KraFusion changed the title Documentation Correction HADOOP-18114. Documentation Correction Feb 4, 2022
@KraFusion
Copy link
Contributor Author

HADOOP-18114

ayushtkn
ayushtkn approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steveloughran
Copy link
Contributor

+1 from me, merging

@steveloughran steveloughran merged commit a08e69d into apache:trunk Feb 9, 2022
asfgit pushed a commit that referenced this pull request Feb 9, 2022
@KraFusion @steveloughran
HADOOP-18114. Documentation correction in assumed_roles.md (#3949)
84de160 
Fixes typo in hadoop-aws/assumed_roles.md

Contributed by Joey Krabacher

Change-Id: I2b77bd7793ae0433196b77042d5f400d0bcbe745
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@KraFusion
HADOOP-18114. Documentation correction in assumed_roles.md (apache#3949)
fe86b7e 
Fixes typo in hadoop-aws/assumed_roles.md

Contributed by Joey Krabacher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannycjones dannycjones dannycjones approved these changes

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KraFusion @hadoop-yetus @steveloughran @dannycjones @ayushtkn