HDFS-16428. Source path with storagePolicy cause wrong typeConsumed while rename #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThinkerLei
changed the title
ThinkerLei
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ayushtkn
reviewed
Jan 19, 2022
Comment on lines
984
to
986
| dfs.rename(bs2, bs1); | ||
| assertTrue("rename with storage policy, typeConsumed should not be 0.", | ||
| dfs.getQuotaUsage(bs1).getTypeConsumed(StorageType.SSD) != 0); |
There was a problem hiding this comment.
Check for the storage policy of bs1 after the rename.
dfs.getStoragePolicy(bs1)
It will be HOT not ONE_SSD. Once you have renamed the file another location, which uses another policy. It will show that only.
After sometime the Namenode would move the block from SSD to DISK. The behaviour looks like the default behaviour. (By Design)
There was a problem hiding this comment.
@ayushtkn thank you very much for your comment. Yes, directory bs1 is hot but its subdirectory bs2 is setted one_ssd. In this situation, dir bs2 will use itself block storage policy rather than his parent storage policy, is it?
There was a problem hiding this comment.
Hmm, Thanx @ThinkerLei for confirming.
Rechecking, seems correct. The issue and fix makes sense to me.
ayushtkn
reviewed
Jan 19, 2022
There was a problem hiding this comment.
There are some checkstyle warnings reported by Jenkins:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3898/2/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
Other than that Changes LGTM
|
🎊 +1 overall
This message was automatically generated. |
| @@ -339,6 +339,13 @@ public boolean isFile() { | |||
| return false; | |||
| } | |||
|
|
|||
| public boolean isSetStoragePolicy() { | |||
There was a problem hiding this comment.
A minor comment. It will be good if we add a comment to this method. People may confuse about "inheriting storage policy from its parent" and "containing storage policy itself". Add a comment like getStoragePolicyID() and getLocalStoragePolicyID().
There was a problem hiding this comment.
@wojiaodoubao thank you very much for your comment. I had fixed it and repush it.
| final boolean isSrcSetSp = src.getLastINode().isSetStoragePolicy(); | ||
| final byte storagePolicyID = isSrcSetSp ? | ||
| src.getLastINode().getLocalStoragePolicyID() : | ||
| dstParent.getStoragePolicyID(); | ||
| final QuotaCounts delta = src.getLastINode() |
There was a problem hiding this comment.
Can we also add a test case to verify the quota check part.
…sumed in rename operation
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Hexiaoqiao
approved these changes
Jan 23, 2022
There was a problem hiding this comment.
LGTM. +1 from my side.
The checkstyle error seems not related to this changes. @ThinkerLei would you mind to give another double check?
|
🎊 +1 overall
This message was automatically generated. |
Hexiaoqiao
changed the title
asfgit
pushed a commit
that referenced
this pull request
Mar 12, 2022
…hile rename (#3898). Contributed by lei w. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
steveloughran
pushed a commit
to steveloughran/hadoop
that referenced
this pull request
Apr 5, 2022
…hile rename (apache#3898). Contributed by lei w. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Apr 13, 2022
…hile rename (#3898). Contributed by lei w. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Apr 14, 2022
…hile rename (#3898). Contributed by lei w. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…hile rename (apache#3898). Contributed by lei w. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.