HDFS-16411 RBF: RouterId is NULL when disable RourterRpcServer #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
…nable=false; modify TestRouterHeartbeatService
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jan 12, 2022
...adoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouter.java
Show resolved
Hide resolved
…nable=false; modify testSwitchRouter()
|
💔 -1 overall
This message was automatically generated. |
…nable=false; checkstyle
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jan 13, 2022
| assertRouterHeartbeater(true, false); | ||
| assertRouterHeartbeater(false, true); | ||
| assertRouterHeartbeater(false, false); | ||
| assertRouterHeartbeater(true,true, true); |
There was a problem hiding this comment.
Watch the spaces after the comma.
There was a problem hiding this comment.
Thanks for your advice. In the latest commit e208d71 , it has been done.
Suggested change
| assertRouterHeartbeater(true,true, true); | |
| assertRouterHeartbeater(true, true, true); |
goiri
reviewed
Jan 14, 2022
| RBFConfigKeys.DFS_ROUTER_RPC_ADDRESS_DEFAULT, | ||
| RBFConfigKeys.DFS_ROUTER_RPC_PORT_DEFAULT); | ||
|
|
||
| String hostname = InetAddress.getLocalHost().getHostName(); |
There was a problem hiding this comment.
Most of this is already defined in setRpcServerAddress() and it even considers exception, etc.
I would refactor that function to allow specifying a customized port.
In any case, I would leave the general code as it was, and then after that, check if routerId is null, and then set it to this.
There was a problem hiding this comment.
Thanks for your advice. The method setRpcServerAddress() is only called when rpc.enable is true. Maybe we can add a new method after that and check routerid.
goiri
reviewed
Jan 14, 2022
| @@ -76,6 +75,8 @@ public void setup() throws Exception { | |||
| curatorFramework.start(); | |||
| routerConfig.set(CommonConfigurationKeys.ZK_ADDRESS, connectStr); | |||
| router.init(routerConfig); | |||
| // set custom routerid after router.init() | |||
| router.setRouterId(routerId); | |||
There was a problem hiding this comment.
Wouldnt init already trigger this with the new code change?
Or we need to force the specific routerId?
There was a problem hiding this comment.
If set the specific routerid,we use the specific routerid; otherwise we use the routerid generated by Router.serviceInit.
…nable=false; checkstyle
…nable=false; checkstyle
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jan 18, 2022
...ct/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Router.java
Outdated
Show resolved
Hide resolved
...ct/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Router.java
Show resolved
Hide resolved
...ct/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Router.java
Show resolved
Hide resolved
…nable=false; checkstyle
|
💔 -1 overall
This message was automatically generated. |
…nable=false; checkstyle
…nable=false; checkstyle
|
💔 -1 overall
This message was automatically generated. |
|
TestRouterDistCpProcedure seems to be failing consistently. |
goiri
approved these changes
Jan 24, 2022
|
Yeps, have seen this failing quite often, mostly a timeout issue, increasing the timeout in the test should fix it, I think so. Not sure why but our builds are getting slower and slower... |
|
@goiri Whether we continue this PR，or close it |
|
According to @ayushtkn, the failures are not introduced by this work so let's go with it. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: HDFS-16411
When dfs.federation.router.rpc.enable=false, routerid is null, but RouterHeartbeatService need updateStateStore() with routerId.