-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16355. Improve block scanner desc #3724
Conversation
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
conf.setLong(DFS_BLOCK_SCANNER_VOLUME_BYTES_PER_SECOND, -1L); | ||
TestContext ctx = new TestContext(conf, 1); | ||
try { | ||
Assert.assertFalse(ctx.datanode.getBlockScanner().isEnabled()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a static import for assertFalse, you don't need the prefix Assert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ayushtkn for your careful review, have just updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems it's still not updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jojochuang for you review, sorry for long time no reply, just have updated the comment.
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@ayushtkn @aajisaka @jojochuang Could you kindly help review if the change is ok,thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: Would you use try-with-resources for ctx
in the test?
|
🎊 +1 overall
This message was automatically generated. |
Thank you @GuoPhilipse! |
….per.second (apache#3724) Co-authored-by: gf13871 <gf13871@ly.com> Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 046a620) Change-Id: I2cae5d1c27a492d896da5338a92c7a86f88a8b43
….per.second (apache#3724) Co-authored-by: gf13871 <gf13871@ly.com> Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 046a620) Change-Id: I2cae5d1c27a492d896da5338a92c7a86f88a8b43
….per.second (apache#3724) Co-authored-by: gf13871 <gf13871@ly.com> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
HDFS-16355
datanode block scanner will be disabled if
dfs.block.scanner.volume.bytes.per.second
is configured less then or equal to zero, we can improve the desciption