HDFS-16351. add path exception information in FSNamesystem#3713
Merged
ayushtkn merged 21 commits intoapache:trunkfrom Dec 7, 2021
Merged
HDFS-16351. add path exception information in FSNamesystem#3713ayushtkn merged 21 commits intoapache:trunkfrom
ayushtkn merged 21 commits intoapache:trunkfrom
Conversation
virajjasani
reviewed
Nov 23, 2021
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
Can you please also add a test?
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
Thanks @virajjasani for your review .test case have just updated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
Nov 24, 2021
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
Thanks for writing the test @GuoPhilipse. Could you also add one additional test in TestDFSPermission because that way we can also test creating some file and then test checkAccess() through FileSystem#access with existing and non-existing files? This way we will have coverage for Mockito (as you did) as well as HDFS FS API.
Thanks
Member
Author
Sure, have just updated. thanks for reminding me @virajjasani |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
Thanks @GuoPhilipse. The changes look good, could you please address 4 checkstyle warnings provided by QA bot? |
Member
Author
Thanks @virajjasani ,have just fix the checkstyle |
|
💔 -1 overall
This message was automatically generated. |
virajjasani
approved these changes
Nov 26, 2021
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
+1 (non-binding), thanks @GuoPhilipse
|
🎊 +1 overall
This message was automatically generated. |
ayushtkn
requested changes
Dec 4, 2021
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
Outdated
Show resolved
Hide resolved
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
Outdated
Show resolved
Hide resolved
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
Show resolved
Hide resolved
Comment on lines
+126
to
+129
| @Test | ||
| public void testCheckAccess() throws IOException { | ||
| Configuration conf = new Configuration(); | ||
| FSImage fsImage = Mockito.mock(FSImage.class); |
Member
There was a problem hiding this comment.
Remove this, one test is enough, we need not to mock and try
ayushtkn
approved these changes
Dec 4, 2021
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Thanx @GuoPhilipse for the update.
Just correct the import order.
Apart changes LGTM, Will commit once updated and we get a clean build!!!
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
approved these changes
Dec 4, 2021
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Changes LGTM.
Will commit later today, if no complains from Jenkins...
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
Dec 4, 2021
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
Thanks @GuoPhilipse, looks good now. |
Member
|
Merged, Thanx Everyone!!! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…). Contributed by guophilipse. Reviewed-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add path information in exception message to make message more clear in FSNamesystem