Skip to content

HADOOP-18021. Provide a public wrapper of Configuration#substituteVars #3710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2021

Conversation

9uapaw
Copy link
Contributor

@9uapaw 9uapaw commented Nov 23, 2021

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@steveloughran steveloughran changed the title YARN-11013. Provide a public wrapper of Configuration#substituteVars HADOOP-18021. Provide a public wrapper of Configuration#substituteVars Nov 23, 2021
Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. At least its surfaced before things shipped -right?

made a hadoop- JIRA as its only touching hadoop-common; the final commit message should refer to the yarn issues which caused it, so that git log --grep for those issues find this too.

You will need a test! just to make sure the method continues to work in future.

@9uapaw
Copy link
Contributor Author

9uapaw commented Nov 24, 2021

Thanks for the suggestions @steveloughran. I am not sure about the tests however, what do you have in mind? Variable substitution is already tested in TestConfiguration#testVariableSubstitution.

@steveloughran
Copy link
Contributor

just make sure the new public method does some substitution -simply to make sure the wire up never breaks

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 12m 55s Maven dependency ordering for branch
+1 💚 mvninstall 28m 19s trunk passed
+1 💚 compile 30m 27s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 25m 28s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 4m 26s trunk passed
+1 💚 mvnsite 3m 21s trunk passed
+1 💚 javadoc 2m 30s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 2m 53s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 5m 46s trunk passed
+1 💚 shadedclient 27m 27s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for patch
+1 💚 mvninstall 2m 23s the patch passed
+1 💚 compile 29m 18s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 29m 18s the patch passed
+1 💚 compile 25m 10s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 25m 9s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 4m 28s the patch passed
+1 💚 mvnsite 3m 21s the patch passed
+1 💚 javadoc 2m 24s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 3m 0s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 6m 12s the patch passed
+1 💚 shadedclient 27m 21s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 20m 1s hadoop-common in the patch passed.
+1 💚 unit 111m 57s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 asflicense 0m 57s The patch does not generate ASF License warnings.
382m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3710/3/artifact/out/Dockerfile
GITHUB PR #3710
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 1b8506f55473 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c5965b8
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3710/3/testReport/
Max. process+thread count 1318 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3710/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@9uapaw
Copy link
Contributor Author

9uapaw commented Nov 30, 2021

@steveloughran I have added a new test case to provide a safety net.

@apache apache deleted a comment from hadoop-yetus Dec 3, 2021
@apache apache deleted a comment from hadoop-yetus Dec 3, 2021
@steveloughran steveloughran merged commit 47ea0d7 into apache:trunk Dec 3, 2021
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
…ubstituteVars (apache#3710)

Contributed by Andras Gyori

(cherry picked from commit 47ea0d7)
Change-Id: I444ddba12442c039c8098b9ca0c312b86f1f0e37
(cherry picked from commit fd36e50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants