-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16324. Fix error log in BlockManagerSafeMode #3661
Conversation
This comment has been minimized.
This comment has been minimized.
@tomscut Could you kindly help verify, the test error seems not related with the patch. |
Can you commit an empty commit to trigger the builder again? |
sure, have just triggered |
This comment has been minimized.
This comment has been minimized.
@tomscut the tests rerun ok 💯 :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… into fixwrongdecisionvalue
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In general I think we can survive without a test case also for log level changes…
Will hold it for Akira to have a final look.
...fs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockManagerSafeMode.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx @GuoPhilipse for the fix. have dropped a nit.
Will commit once addressed.
...fs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockManagerSafeMode.java
Outdated
Show resolved
Hide resolved
Thanks @ayushtkn for your careful review, have updated the code |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🎊 +1 overall
This message was automatically generated. |
...fs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockManagerSafeMode.java
Outdated
Show resolved
Hide resolved
Merged. Thank you @GuoPhilipse for your contribution and thanks @tomscut @ayushtkn for your reviews. |
Reviewed-by: tomscut <litao@bigo.sg> Reviewed-by: Ayush Saxena <ayushsaxena@apache.org> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Description of PR
if
recheckInterval
was set as invalid value, there will be warning log output, but the message seems not that proper ,we can improve it.How was this patch tested?
No need test cases, just update warning log.