HDFS-16321. Fix invalid config in TestAvailableSpaceRackFaultTolerantBPP #3655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushtkn
reviewed
Nov 13, 2021
Comment on lines
192
to
198
| @Test | ||
| public void testDefaultConfigValue() { | ||
| Assert.assertEquals( | ||
| conf.get("DFS_NAMENODE_AVAILABLE_SPACE_RACK_FAULT_TOLERANT_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_PREFERENCE_FRACTION_KEY") | ||
| ,0.6f); | ||
| } | ||
|
|
There was a problem hiding this comment.
This isn't required, this isn't checking the BPP, but how the conf object works. you can remove this test.
There was a problem hiding this comment.
This isn't required, this isn't checking the BPP, but how the conf object works. you can remove this test.
Thanks @ayushtkn for your review. I have removed the test case, but not sure if the CI will pass if no tests added. hope it works.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@ayushtkn Could you kindly help check the timeout cases, I have tried twice ,the errors seem not related with this patch, and they occurs in different methods, |
ayushtkn
approved these changes
Nov 14, 2021
asfgit
pushed a commit
that referenced
this pull request
Nov 14, 2021
…BPP (#3655). Contributed by guo. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…BPP (apache#3655). Contributed by guo. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestAvailableSpaceRackFaultTolerantBPPseems setting invalid param(valid inTestAvailableSpaceBlockPlacementPolicy), we can fix it to avoid further trouble.