-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16285. Make HDFS ownership tools cross platform #3588
Merged
GauthamBanasandra
merged 18 commits into
apache:trunk
from
GauthamBanasandra:ch-x-platform
Dec 9, 2021
Merged
HDFS-16285. Make HDFS ownership tools cross platform #3588
GauthamBanasandra
merged 18 commits into
apache:trunk
from
GauthamBanasandra:ch-x-platform
Dec 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GauthamBanasandra
force-pushed
the
ch-x-platform
branch
from
October 28, 2021 04:41
3fcc4bf
to
d62f528
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit 4d1ca8de63d09f9d18a49cd82415772f55a7396e.
GauthamBanasandra
force-pushed
the
ch-x-platform
branch
from
November 19, 2021 18:34
1567775
to
bbed73b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
goiri
reviewed
Dec 6, 2021
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tools/hdfs-ownership.h
Outdated
Show resolved
Hide resolved
* Moved these two structs to internal folder.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Dec 7, 2021
🎊 +1 overall
This message was automatically generated. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The source files for hdfs_chown, hdfs_chmod and hdfs_chgrp uses getopt for parsing the command line arguments. getopt is available only on Linux and thus, isn't cross platform. We need to replace getopt with boost::program_options to make these tools cross platform.
How was this patch tested?
I ran the above tools on my Hadoop cluster setup locally. The details of testing are as follows -
hdfs_chgrp
Initially -
Changed the group association of a single file from
hadoop
toyetus
group -Performed the same operation with the recursive option -
Final state of the files viewed through browser -
hdfs_chmod
Initially -
Changed the permissions of a single file to
777
-Performed the same operation with the recursive option -
Final state of the files viewed through browser -
hdfs_chown
Initially -
Changed the ownership of a single file from
hduser
togautham
-Performed the same operation with the recursive option -
Final state of the files viewed through browser -
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?