HADOOP-17968 Migrate checkstyle module illegalimport to maven enforcer banned-illegal-imports #3584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r banned-illegal-imports
|
Could you please take a look @amahussein @tasanuma? |
amahussein
requested changes
Oct 25, 2021
| <bannedImports> | ||
| <bannedImport>org.apache.hadoop.thirdparty.com.google.common.collect.ImmutableListMultimap</bannedImport> | ||
| </bannedImports> | ||
| </restrictImports> |
There was a problem hiding this comment.
Don't we need to keep "sun" packages? it is in the checkstyle illegal-imports
There was a problem hiding this comment.
Shall we take this separately because sun packages are already in use? Classes already in use are:
sun.misc.Unsafe
sun.misc.Signal
sun.misc.SignalHandler
sun.net.spi.nameservice.NameService
There was a problem hiding this comment.
I see!
I think that if the jira is to migrate "guava packages" then we may keep checkstyle.illegal-import entry for sun packages?
Otherwise, if the purpose to remove checkstyle illegal-imports all together, then we can exclude those classes. there is also a flag failBuild if we don't want the build to fail with some patterns.
WDYT?
There was a problem hiding this comment.
I see! I think that if the jira is to migrate "guava packages" then we may keep
checkstyle.illegal-importentry forsun packages?
Sounds good, let me put back sun packages.
There was a problem hiding this comment.
Done. Thanks @amahussein
There was a problem hiding this comment.
I will wait for the yetus report then merge.
amahussein
approved these changes
Oct 25, 2021
|
Since it added |
|
Could you match the format of the text in the reason tags with other reason tags? |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Done, thanks @tasanuma |
|
@amahussein @tasanuma JFYI, the builds take almost 24 hr time (some builds timed out as well) since the change is done in hadoop-main pom. |
|
@virajjasani Thanks for updating it. +1, pending CI. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
tasanuma
approved these changes
Oct 28, 2021
|
Thanks for your contribution, @virajjasani. Thanks for your review, @amahussein. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…r banned-illegal-imports (apache#3584) Reviewed-by: Ahmed Hussein <ahussein@apache.org> Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
As discussed on PR #3503, we should migrate existing imports provided in IllegalImport tag in checkstyle.xml to maven-enforcer-plugin's banned-illegal-imports enforcer rule so that build never succeeds in the presence of any of the illegal imports.
For code changes: