Skip to content

Conversation

@yuriymalygin
Copy link

Fix possible NPE when yarn.resourcemanager.webapp.address or yarn.resourcemanager.webapp.https.address is not set in yarn-site.xml (incomplete configuration of HA).

Fix possible NPE when yarn.resourcemanager.webapp.address or yarn.resourcemanager.webapp.https.address is not set in yarn-site.xml (incomplete configuration of HA).
@yuriymalygin
Copy link
Author

Create issue - https://issues.apache.org/jira/browse/YARN-8056.

@bak12

This comment has been minimized.

@bak12

This comment has been minimized.

@bak12

This comment has been minimized.

@yuriymalygin yuriymalygin changed the title Fix possible NPE when start Application Master YARN-8056. Fix possible NPE when start Application Master Mar 22, 2018
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 71 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1220 trunk passed
+1 compile 28 trunk passed
+1 checkstyle 18 trunk passed
+1 mvnsite 32 trunk passed
+1 shadedclient 789 branch has no errors when building and testing our client artifacts.
+1 javadoc 22 trunk passed
0 spotbugs 48 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 46 trunk passed
_ Patch Compile Tests _
+1 mvninstall 26 the patch passed
+1 compile 23 the patch passed
+1 javac 23 the patch passed
+1 checkstyle 12 the patch passed
+1 mvnsite 27 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 880 patch has no errors when building and testing our client artifacts.
+1 javadoc 19 the patch passed
+1 findbugs 48 the patch passed
_ Other Tests _
+1 unit 55 hadoop-yarn-server-web-proxy in the patch passed.
+1 asflicense 28 The patch does not generate ASF License warnings.
3433
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/1/artifact/out/Dockerfile
GITHUB PR #356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux f7dd76f5eddb 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 7f1b76c
Default Java 1.8.0_212
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-356/1/testReport/
Max. process+thread count 306 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-356/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 39 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1067 trunk passed
+1 compile 24 trunk passed
+1 checkstyle 15 trunk passed
+1 mvnsite 25 trunk passed
+1 shadedclient 633 branch has no errors when building and testing our client artifacts.
+1 javadoc 19 trunk passed
0 spotbugs 37 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 35 trunk passed
_ Patch Compile Tests _
+1 mvninstall 22 the patch passed
+1 compile 19 the patch passed
+1 javac 19 the patch passed
+1 checkstyle 11 the patch passed
+1 mvnsite 22 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 681 patch has no errors when building and testing our client artifacts.
+1 javadoc 16 the patch passed
+1 findbugs 40 the patch passed
_ Other Tests _
+1 unit 52 hadoop-yarn-server-web-proxy in the patch passed.
+1 asflicense 26 The patch does not generate ASF License warnings.
2830
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/2/artifact/out/Dockerfile
GITHUB PR #356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 80b088d0009a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c01e137
Default Java 1.8.0_212
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-356/2/testReport/
Max. process+thread count 446 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-356/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 64 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1044 trunk passed
+1 compile 30 trunk passed
+1 checkstyle 17 trunk passed
+1 mvnsite 29 trunk passed
+1 shadedclient 711 branch has no errors when building and testing our client artifacts.
+1 javadoc 18 trunk passed
0 spotbugs 40 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 39 trunk passed
_ Patch Compile Tests _
+1 mvninstall 22 the patch passed
+1 compile 21 the patch passed
+1 javac 21 the patch passed
+1 checkstyle 11 the patch passed
+1 mvnsite 22 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 704 patch has no errors when building and testing our client artifacts.
+1 javadoc 16 the patch passed
+1 findbugs 43 the patch passed
_ Other Tests _
+1 unit 50 hadoop-yarn-server-web-proxy in the patch passed.
+1 asflicense 24 The patch does not generate ASF License warnings.
2944
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/3/artifact/out/Dockerfile
GITHUB PR #356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux f95f6b6ab0fc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e872ceb
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-356/3/testReport/
Max. process+thread count 414 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-356/3/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 62 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1088 trunk passed
+1 compile 33 trunk passed
+1 checkstyle 18 trunk passed
+1 mvnsite 27 trunk passed
+1 shadedclient 711 branch has no errors when building and testing our client artifacts.
+1 javadoc 16 trunk passed
0 spotbugs 35 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 33 trunk passed
_ Patch Compile Tests _
+1 mvninstall 18 the patch passed
+1 compile 15 the patch passed
+1 javac 15 the patch passed
+1 checkstyle 11 the patch passed
+1 mvnsite 18 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 699 patch has no errors when building and testing our client artifacts.
+1 javadoc 15 the patch passed
+1 findbugs 39 the patch passed
_ Other Tests _
+1 unit 49 hadoop-yarn-server-web-proxy in the patch passed.
+1 asflicense 26 The patch does not generate ASF License warnings.
2969
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/4/artifact/out/Dockerfile
GITHUB PR #356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 4544f37b3578 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 00b5a27
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-356/4/testReport/
Max. process+thread count 413 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-356/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1052 trunk passed
+1 compile 19 trunk passed
+1 checkstyle 13 trunk passed
+1 mvnsite 20 trunk passed
+1 shadedclient 639 branch has no errors when building and testing our client artifacts.
+1 javadoc 16 trunk passed
0 spotbugs 32 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 31 trunk passed
_ Patch Compile Tests _
+1 mvninstall 18 the patch passed
+1 compile 14 the patch passed
+1 javac 14 the patch passed
+1 checkstyle 10 the patch passed
+1 mvnsite 16 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 692 patch has no errors when building and testing our client artifacts.
+1 javadoc 15 the patch passed
+1 findbugs 36 the patch passed
_ Other Tests _
+1 unit 45 hadoop-yarn-server-web-proxy in the patch passed.
+1 asflicense 22 The patch does not generate ASF License warnings.
2785
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/5/artifact/out/Dockerfile
GITHUB PR #356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 4cf554282091 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e356e4f
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-356/5/testReport/
Max. process+thread count 412 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-356/5/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 41 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1056 trunk passed
+1 compile 18 trunk passed
+1 checkstyle 13 trunk passed
+1 mvnsite 19 trunk passed
+1 shadedclient 653 branch has no errors when building and testing our client artifacts.
+1 javadoc 16 trunk passed
0 spotbugs 31 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 29 trunk passed
_ Patch Compile Tests _
+1 mvninstall 19 the patch passed
+1 compile 14 the patch passed
+1 javac 14 the patch passed
+1 checkstyle 11 the patch passed
+1 mvnsite 16 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 689 patch has no errors when building and testing our client artifacts.
+1 javadoc 16 the patch passed
+1 findbugs 38 the patch passed
_ Other Tests _
+1 unit 47 hadoop-yarn-server-web-proxy in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
2809
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/6/artifact/out/Dockerfile
GITHUB PR #356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 2aeb23be1a97 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 094d736
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-356/6/testReport/
Max. process+thread count 447 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-356/6/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 78 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1304 trunk passed
+1 compile 22 trunk passed
+1 checkstyle 18 trunk passed
+1 mvnsite 23 trunk passed
+1 shadedclient 786 branch has no errors when building and testing our client artifacts.
+1 javadoc 21 trunk passed
0 spotbugs 37 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 34 trunk passed
_ Patch Compile Tests _
+1 mvninstall 23 the patch passed
+1 compile 16 the patch passed
+1 javac 16 the patch passed
+1 checkstyle 12 the patch passed
+1 mvnsite 18 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 855 patch has no errors when building and testing our client artifacts.
+1 javadoc 19 the patch passed
+1 findbugs 42 the patch passed
_ Other Tests _
+1 unit 54 hadoop-yarn-server-web-proxy in the patch passed.
+1 asflicense 27 The patch does not generate ASF License warnings.
3458
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/7/artifact/out/Dockerfile
GITHUB PR #356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 3aa0a6ddc7e8 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 61b2df2
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-356/7/testReport/
Max. process+thread count 306 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-356/7/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 179 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1300 trunk passed
+1 compile 26 trunk passed
+1 checkstyle 20 trunk passed
+1 mvnsite 31 trunk passed
+1 shadedclient 854 branch has no errors when building and testing our client artifacts.
+1 javadoc 25 trunk passed
0 spotbugs 41 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 39 trunk passed
_ Patch Compile Tests _
+1 mvninstall 24 the patch passed
+1 compile 20 the patch passed
+1 javac 20 the patch passed
+1 checkstyle 14 the patch passed
+1 mvnsite 21 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 919 patch has no errors when building and testing our client artifacts.
+1 javadoc 20 the patch passed
+1 findbugs 48 the patch passed
_ Other Tests _
+1 unit 59 hadoop-yarn-server-web-proxy in the patch passed.
+1 asflicense 33 The patch does not generate ASF License warnings.
3742
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/8/artifact/out/Dockerfile
GITHUB PR #356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 878d972a426d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3329257
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-356/8/testReport/
Max. process+thread count 411 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-356/8/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 11 #356 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-356/9/console
versions git=2.17.1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Author: Dong Lin <lindong28@gmail.com>

Reviewers: Prateek Maheshwari <prateekm@apache.org>

Closes apache#356 from lindong28/SAMZA-1490
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 17s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 21m 1s trunk passed
+1 💚 compile 0m 29s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 0m 23s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 checkstyle 0m 20s trunk passed
+1 💚 mvnsite 0m 25s trunk passed
+1 💚 shadedclient 14m 44s branch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 25s hadoop-yarn-server-web-proxy in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚 javadoc 0m 20s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗 spotbugs 0m 48s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 46s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 22s the patch passed
+1 💚 compile 0m 20s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 0m 20s the patch passed
+1 💚 compile 0m 17s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 javac 0m 17s the patch passed
+1 💚 checkstyle 0m 12s the patch passed
+1 💚 mvnsite 0m 20s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 10s patch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 21s hadoop-yarn-server-web-proxy in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚 javadoc 0m 23s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 findbugs 0m 46s the patch passed
_ Other Tests _
+1 💚 unit 0m 54s hadoop-yarn-server-web-proxy in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
60m 48s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/artifact/out/Dockerfile
GITHUB PR #356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 26835a5fff23 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 5d8600e
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/testReport/
Max. process+thread count 413 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member

-1
I think MR AppMaster should fail to start if the HA configuration is incomplete.

AmFilterInitializer#initFilter should check if the URL is null but it should throw some RuntimeException if the URL is null. In addition, MRClientService#serviceStart should not catch exceptions when starting webapp.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 53s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 49s trunk passed
+1 💚 compile 0m 30s trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 compile 0m 23s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 0m 23s trunk passed
+1 💚 mvnsite 0m 30s trunk passed
+1 💚 javadoc 0m 27s trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 24s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 0m 48s trunk passed
+1 💚 shadedclient 23m 31s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 22s the patch passed
+1 💚 compile 0m 21s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javac 0m 21s the patch passed
+1 💚 compile 0m 19s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 19s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 12s the patch passed
+1 💚 mvnsite 0m 33s the patch passed
+1 💚 javadoc 0m 16s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 16s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 15s the patch passed
+1 💚 shadedclient 24m 25s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 1m 9s hadoop-yarn-server-web-proxy in the patch passed.
+1 💚 asflicense 0m 31s The patch does not generate ASF License warnings.
94m 28s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/1/artifact/out/Dockerfile
GITHUB PR #356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 1c202eb2b3b3 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 0a6fef7
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/1/testReport/
Max. process+thread count 521 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member

Closing this due to no activity.

@aajisaka aajisaka closed this Feb 25, 2022
NyteKnight pushed a commit to NyteKnight/hadoop that referenced this pull request Jun 25, 2024
…ache#4… (apache#356)

* HADOOP-18365. Update the remote address when a change is detected (apache#4692) (apache#4768)

Back port to branch-3.3, to avoid reconnecting to the old address after detecting that the address has been updated.

* Use a stable hashCode to allow safe IP addr changes
* Add test that updated address is used

Once the address has been updated, it will be used in future calls.  Test verifies that a second request succeeds and that it uses the existing updated address instead of having to re-resolve.

Co-authored-by: Steve Vaughan Jr <s_vaughan@apple.com>

* ACLOVERRIDE

---------

Co-authored-by: Steve Vaughan <email@stevevaughan.me>
Co-authored-by: Steve Vaughan Jr <s_vaughan@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants