Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17925. BUILDING.txt should not encourage to activate docs profile on building binary artifacts. #3509

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

iwasakims
Copy link
Member

https://issues.apache.org/jira/browse/HADOOP-17925

If -Pdocs is activated, hadoop-client depends on xerces. The dependency was added by HADOOP-14835 to fix jdiff error. We are avoiding unwanted dependency by building documentations alone in the second pass after building binary artifacts. The BUILDING.txt just should not encourage to activate -Pdocs on building binary artifacts.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 17m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 27m 28s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 20m 51s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
67m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3509/1/artifact/out/Dockerfile
GITHUB PR #3509
Optional Tests dupname asflicense codespell
uname Linux a53eb31a50d3 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / a10371c
Max. process+thread count 593 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3509/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 make sense to me.

@iwasakims iwasakims merged commit 65d9523 into apache:trunk Oct 11, 2021
@iwasakims
Copy link
Member Author

Thanks, @jojochuang and @aajisaka. I'm merging this.

iwasakims added a commit that referenced this pull request Oct 11, 2021
…ile on building binary artifacts. (#3509)

(cherry picked from commit 65d9523)
iwasakims added a commit that referenced this pull request Oct 11, 2021
…ile on building binary artifacts. (#3509)

(cherry picked from commit 65d9523)
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants