HADOOP-17929. implement non-guava Precondition checkArgument #3473

amahussein · 2021-09-23T13:27:40Z

Description of PR

As part In order to replace Guava Preconditions, we need to implement our own versions of the API.
This Jira is to add the implementation checkArgument to the existing class org.apache.hadoop.util.Preconditions

How was this patch tested?

Extended the unit test org.apache.hadoop.util.TestPreconditions

Added testCheckArgumentWithSuccess()
Added testCheckArgumentWithFailure()

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id: HADOOP-17929
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?

hadoop-yetus · 2021-09-23T17:14:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 58s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 7s		trunk passed
+1 💚	compile	27m 36s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	22m 41s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	1m 4s		trunk passed
+1 💚	mvnsite	1m 45s		trunk passed
+1 💚	javadoc	1m 11s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 48s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	2m 47s		trunk passed
+1 💚	shadedclient	25m 33s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 6s		the patch passed
+1 💚	compile	26m 28s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	26m 28s		the patch passed
+1 💚	compile	22m 45s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	22m 45s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 4s	/results-checkstyle-hadoop-common-project_hadoop-common.txt	hadoop-common-project/hadoop-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	mvnsite	1m 41s		the patch passed
+1 💚	javadoc	1m 9s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 46s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 1s		the patch passed
+1 💚	shadedclient	25m 28s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 50s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 53s		The patch does not generate ASF License warnings.
		224m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3473/1/artifact/out/Dockerfile
GITHUB PR	#3473
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 0260c8438987 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / f1aaffb781c4466e34bd1ce53769e7aeecea035c
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3473/1/testReport/
Max. process+thread count	1351 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3473/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

amahussein · 2021-09-23T19:49:28Z

@virajjasani can you please take a look at the changes?

hadoop-yetus · 2021-09-23T22:48:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 59s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
-1 ❌	mvninstall	10m 15s	/branch-mvninstall-root.txt	root in trunk failed.
+1 💚	compile	33m 31s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	19m 34s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	1m 0s		trunk passed
+1 💚	mvnsite	1m 32s		trunk passed
+1 💚	javadoc	1m 5s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 34s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	2m 25s		trunk passed
+1 💚	shadedclient	23m 51s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 57s		the patch passed
+1 💚	compile	22m 10s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	22m 10s		the patch passed
+1 💚	compile	19m 27s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	19m 27s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 58s		the patch passed
+1 💚	mvnsite	1m 29s		the patch passed
+1 💚	javadoc	1m 1s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 33s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	2m 34s		the patch passed
+1 💚	shadedclient	23m 56s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 12s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 16s		The patch does not generate ASF License warnings.
		189m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3473/2/artifact/out/Dockerfile
GITHUB PR	#3473
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux a31f1cb32795 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 9865034cfc77e148621c8cce8d07ca6bb539257c
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3473/2/testReport/
Max. process+thread count	1236 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3473/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

virajjasani · 2021-09-30T06:53:20Z

Thanks @amahussein, changes look good. Looks like mvninstall failure in the latest QA result is not relevant. Good to rerun the build?

amahussein · 2021-09-30T17:56:22Z

Thanks @amahussein, changes look good. Looks like mvninstall failure in the latest QA result is not relevant. Good to rerun the build?

Thanks @virajjasani !
the mvninstall is in the root and it it is not related to the patch.
I rebased to trigger a new build. I hope that the yetus passes this random failure. We are getting close to get rid of the Preconditions ! Yay!

hadoop-yetus · 2021-09-30T20:57:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	31m 44s		trunk passed
+1 💚	compile	21m 27s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	18m 41s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	1m 6s		trunk passed
+1 💚	mvnsite	1m 37s		trunk passed
+1 💚	javadoc	1m 10s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 41s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	2m 27s		trunk passed
+1 💚	shadedclient	20m 55s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 55s		the patch passed
+1 💚	compile	20m 34s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	20m 34s		the patch passed
+1 💚	compile	18m 34s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	18m 34s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 6s		the patch passed
+1 💚	mvnsite	1m 37s		the patch passed
+1 💚	javadoc	1m 7s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 41s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	2m 34s		the patch passed
+1 💚	shadedclient	21m 10s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 28s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 59s		The patch does not generate ASF License warnings.
		189m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3473/3/artifact/out/Dockerfile
GITHUB PR	#3473
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 43a68afad01d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f8c6463`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3473/3/testReport/
Max. process+thread count	1266 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3473/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jojochuang · 2021-10-01T02:29:20Z

@virajjasani you good with the latest run?

virajjasani · 2021-10-01T06:00:28Z

Yes, looks good. +1 (non-binding) from my side. Thank you @amahussein @jojochuang

Reviewed-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 0c498f2)

…3473) Reviewed-by: Viraj Jasani <vjasani@apache.org>

amahussein force-pushed the hadoop-17929 branch from f1aaffb to 9865034 Compare September 23, 2021 19:37

amahussein added 2 commits September 30, 2021 09:58

HADOOP-17929. implement non-guava Precondition checkArgument

4ae4f89

HADOOP-17929. fix style warning

f8c6463

amahussein force-pushed the hadoop-17929 branch from 9865034 to f8c6463 Compare September 30, 2021 17:46

jojochuang merged commit 0c498f2 into apache:trunk Oct 1, 2021

asfgit pushed a commit that referenced this pull request Oct 1, 2021

HADOOP-17929. implement non-guava Precondition checkArgument (#3473)

31b44c5

Reviewed-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 0c498f2)

tasanuma pushed a commit that referenced this pull request Oct 7, 2021

HADOOP-17929. implement non-guava Precondition checkArgument (#3473)

4b6316a

Reviewed-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 0c498f2)

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HADOOP-17929. implement non-guava Precondition checkArgument (apache#…

cee78d4

…3473) Reviewed-by: Viraj Jasani <vjasani@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-17929. implement non-guava Precondition checkArgument #3473

HADOOP-17929. implement non-guava Precondition checkArgument #3473

Uh oh!

amahussein commented Sep 23, 2021

Uh oh!

hadoop-yetus commented Sep 23, 2021

Uh oh!

amahussein commented Sep 23, 2021

Uh oh!

hadoop-yetus commented Sep 23, 2021

Uh oh!

virajjasani commented Sep 30, 2021

Uh oh!

amahussein commented Sep 30, 2021

Uh oh!

hadoop-yetus commented Sep 30, 2021

Uh oh!

jojochuang commented Oct 1, 2021

Uh oh!

virajjasani commented Oct 1, 2021

Uh oh!

Uh oh!

HADOOP-17929. implement non-guava Precondition checkArgument #3473

HADOOP-17929. implement non-guava Precondition checkArgument #3473

Uh oh!

Conversation

amahussein commented Sep 23, 2021

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Sep 23, 2021

Uh oh!

amahussein commented Sep 23, 2021

Uh oh!

hadoop-yetus commented Sep 23, 2021

Uh oh!

virajjasani commented Sep 30, 2021

Uh oh!

amahussein commented Sep 30, 2021

Uh oh!

hadoop-yetus commented Sep 30, 2021

Uh oh!

jojochuang commented Oct 1, 2021

Uh oh!

virajjasani commented Oct 1, 2021

Uh oh!

Uh oh!