Skip to content

HDFS-16181. [SBN Read] Fix metric of RpcRequestCacheMissAmount can't display when tailEditLog form JN #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2021
Merged

HDFS-16181. [SBN Read] Fix metric of RpcRequestCacheMissAmount can't display when tailEditLog form JN #3317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a5092e
HDFS-16181. [SBN] Fix metric of RpcRequestCacheMissAmount can't displ…
Aug 20, 2021
17ff74e
HDFS-16181. address comment
wzhallright Sep 14, 2021
7767807
HDFS-16181. fix checkstyle
wzhallright Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...dfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,7 @@ public GetJournaledEditsResponseProto getJournaledEdits(long sinceTxId,
.setEditLog(output.toByteString())
.build();
} catch (JournaledEditsCache.CacheMissException cme) {
metrics.rpcRequestCacheMissAmount.add(cme.getCacheMissAmount());
metrics.addRpcRequestCacheMissAmount(cme.getCacheMissAmount());
throw cme;
}
}
Expand Down
16 changes: 10 additions & 6 deletions ...ject/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,7 @@ class JournalMetrics {
@Metric("Number of bytes served via RPC")
MutableCounterLong bytesServedViaRpc;

@Metric
MutableStat rpcRequestCacheMissAmount = new MutableStat(
"RpcRequestCacheMissAmount", "Number of RPC requests unable to be " +
"served due to lack of availability in cache, and how many " +
"transactions away the request was from being in the cache.",
"Misses", "Txns");
private MutableStat rpcRequestCacheMissAmount;

@Metric("Number of RPC requests with zero edits returned")
MutableCounterLong rpcEmptyResponses;
Expand Down Expand Up @@ -87,6 +82,11 @@ class JournalMetrics {
"syncs" + interval + "s",
"Journal sync time", "ops", "latencyMicros", interval);
}
rpcRequestCacheMissAmount = registry
.newStat("RpcRequestCacheMissAmount", "Number of RPC requests unable to be " +
"served due to lack of availability in cache, and how many " +
"transactions away the request was from being in the cache.",
"Misses", "Txns");
}

public static JournalMetrics create(Journal j) {
Expand Down Expand Up @@ -149,4 +149,8 @@ public MutableCounterLong getNumEditLogsSynced() {
public void incrNumEditLogsSynced() {
numEditLogsSynced.incr();
}

public void addRpcRequestCacheMissAmount(long cacheMissAmount) {
rpcRequestCacheMissAmount.add(cacheMissAmount);
}
}