HDFS-14529. SetTimes to throw FileNotFoundException if inode is not found #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ound. Change-Id: I6715b158b5ae3f198178d52cab9645a7b696fe1c
smengcl
approved these changes
Jul 28, 2021
There was a problem hiding this comment.
Nice catch!
Moving the null check inside the unprotected call should mitigate NPE from other call paths.
Pending CI.
ayushtkn
approved these changes
Jul 28, 2021
There was a problem hiding this comment.
Thanx @jojochuang for the change, makes sense to change it to FNF.
But we should try to eliminate the root cause as well in the future if possible. From the jira discussion, I think you have found the root cause as well.
+1
virajjasani
approved these changes
Jul 28, 2021
| @@ -497,10 +492,14 @@ private static void setDirStoragePolicy( | |||
|
|
|||
| static boolean unprotectedSetTimes( | |||
| FSDirectory fsd, INodesInPath iip, long mtime, long atime, boolean force) | |||
| throws QuotaExceededException { | |||
| throws QuotaExceededException, FileNotFoundException { | |||
There was a problem hiding this comment.
nit: looks like throwing QuotaExceededException is redundant here
Change-Id: I816a25b208bcb8c9605c68a1dd7deaee34e221d6
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Change-Id: I6a46aef7cf9ce81d1aebd1072fd45bb75cced3bb
aajisaka
approved these changes
Jul 29, 2021
|
🎊 +1 overall
This message was automatically generated. |
|
Thanks for the review. This is merged now. |
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
…ound (apache#3243) Reviewed-by: Akira Ajisaka <aajisaka@apache.org> Reviewed-by: Viraj Jasani <vjasani@apache.org> Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw FileNotFoundException instead of NPE if inode is not found.
As explained in the corresponding jira, there are two possibilities for this to happen. This PR does not resolve the culprit. I just merely make the exception more graceful.
If this problem is ever hit during edit log loading, NameNode can work around by applying the -recover option.