-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16137.Improve the comments related to FairCallQueue#queues. #3226
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor nits, looks good otherwise
/* | ||
* Save the queue data of multiple priority strategies. | ||
* Usually the number of queue data and priority strategies saved is the same. | ||
* */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: minor change and alignment of comment section:
/**
* Save the queue data of multiple priority strategies as list of blocking queues.
* Usually the number of queue data and priority strategies saved is the same.
*/
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/FairCallQueue.java
Outdated
Show resolved
Hide resolved
@virajjasani , thanks for your comment. I will try to modify and submit some new codes later. |
import java.util.Iterator; | ||
import java.util.AbstractQueue; | ||
import java.util.HashMap; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor code style issue. We typically don't do wildcard imports in Hadoop codebase.
You can configure your IDE to not automatically collapse multiple imports into one wildcard import.
Other than that I am +1
@jojochuang , thanks for your comment. I will try to modify and submit some new codes later. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (non-binding)
💔 -1 overall
This message was automatically generated. |
…che#3226) Co-authored-by: zhujianghua <zhujianghua@zhujianghuadeMacBook-Pro.local> Reviewed-by: Viraj Jasani <vjasani@apache.org>
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute