-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-16078. Remove unused parameters for DatanodeManager.handleLifeli… #3119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
Hi @tasanuma @jojochuang , could you please take a look at this little change? Thanks. |
|
Hi @ayushtkn , could you also help to review it? Thank you. |
jojochuang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Thanks @jojochuang for your review. Could you also help to review those PRs(PR#3120 PR#3117) if you have time. Thanks a lot. : ) |
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…ne() (#3119). Contributed by tomscut. Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
…ne() (#3119). Contributed by tomscut. Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
|
Thanx @tomscut for the contribution and @jojochuang for the review!!! |
…ne() (apache#3119). Contributed by tomscut. Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
JIRA: HDFS-16078
Remove unused parameters (blockPoolId, maxTransfers) for DatanodeManager.handleLifeline().