Skip to content

HADOOP-17661. mvn versions:set fails to parse pom.xml. #2952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2021
Merged

HADOOP-17661. mvn versions:set fails to parse pom.xml. #2952

merged 2 commits into from
Apr 26, 2021

Conversation

@jojochuang
Copy link
Contributor

@jojochuang jojochuang commented Apr 24, 2021

Manual test:

  1. verified that mvn clean build passed
  2. verified that mvn versions:set completes.

@jojochuang
HADOOP-17661. mvn versions:set fails to parse pom.xml.
c56f689 
Change-Id: I7de255cb9a167e3a5e25ae339b050e82cb4b7c30
@hadoop-yetus
Copy link

hadoop-yetus commented Apr 24, 2021

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 21m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 37m 55s trunk passed
+1 💚 compile 0m 17s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 0m 16s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 mvnsite 0m 21s trunk passed
+1 💚 javadoc 0m 20s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 16s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 shadedclient 55m 45s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 15s the patch passed
+1 💚 compile 0m 10s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javac 0m 10s the patch passed
+1 💚 compile 0m 10s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 javac 0m 10s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 14s the patch passed
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 12s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 12s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 shadedclient 17m 13s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 13s hadoop-project in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
97m 40s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2952/1/artifact/out/Dockerfile
GITHUB PR #2952
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname Linux c283af689171 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c56f689
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2952/1/testReport/
Max. process+thread count 519 (vs. ulimit of 5500)
modules C: hadoop-project U: hadoop-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2952/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ferhui
ferhui approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@ferhui ferhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

aajisaka
aajisaka requested changes Apr 26, 2021
View reviewed changes
@jojochuang
Use compilerArgs instead.
94b6222 
Change-Id: I1f23988c17bbd8e8f251b7edbddef18b507923f5
aajisaka
aajisaka approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hadoop-yetus
Copy link

hadoop-yetus commented Apr 26, 2021

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 2s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 37m 21s trunk passed
+1 💚 compile 0m 15s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 0m 18s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 mvnsite 0m 20s trunk passed
+1 💚 javadoc 0m 18s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 18s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 shadedclient 55m 6s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 11s the patch passed
+1 💚 compile 0m 15s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javac 0m 15s the patch passed
+1 💚 compile 0m 10s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 javac 0m 10s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 14s the patch passed
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 12s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 11s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 shadedclient 16m 50s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 13s hadoop-project in the patch passed.
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
76m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2952/2/artifact/out/Dockerfile
GITHUB PR #2952
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname Linux 27758b0d4191 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 94b6222
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2952/2/testReport/
Max. process+thread count 555 (vs. ulimit of 5500)
modules C: hadoop-project U: hadoop-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2952/2/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@jojochuang jojochuang merged commit 66dda86 into apache:trunk Apr 26, 2021
@jojochuang
Copy link
Contributor Author

jojochuang commented Apr 26, 2021

Merged. Thanks Akira and Hui!

asfgit pushed a commit that referenced this pull request Apr 26, 2021
@jojochuang
HADOOP-17661. mvn versions:set fails to parse pom.xml. (#2952)
dc30b34 
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
Reviewed-by: Hui Fei <ferhui@apache.org>
(cherry picked from commit 66dda86)
(cherry picked from commit 41da92def46f84e99e2d8cab604b8f1e290f1c15)
asfgit pushed a commit that referenced this pull request Apr 26, 2021
@jojochuang
HADOOP-17661. mvn versions:set fails to parse pom.xml. (#2952)
d525e1e 
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
Reviewed-by: Hui Fei <ferhui@apache.org>
(cherry picked from commit 66dda86)
asfgit pushed a commit that referenced this pull request Apr 26, 2021
@jojochuang
Revert "HADOOP-17661. mvn versions:set fails to parse pom.xml. (#2952)"
ef197db 
This reverts commit dc30b34.
asfgit pushed a commit that referenced this pull request Apr 26, 2021
@jojochuang
Revert "HADOOP-17661. mvn versions:set fails to parse pom.xml. (#2952)"
1425512 
This reverts commit d525e1e.
asfgit pushed a commit that referenced this pull request Apr 26, 2021
@jojochuang
Revert "HADOOP-17661. mvn versions:set fails to parse pom.xml. (#2952)"
bbf62a0 
This reverts commit 66dda86.
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@jojochuang
HADOOP-17661. mvn versions:set fails to parse pom.xml. (apache#2952)
6fd40c6 
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
Reviewed-by: Hui Fei <ferhui@apache.org>
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@jojochuang
Revert "HADOOP-17661. mvn versions:set fails to parse pom.xml. (apach…
b642354 
…e#2952)"

This reverts commit 66dda86.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ferhui ferhui ferhui approved these changes

@aajisaka aajisaka aajisaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jojochuang @hadoop-yetus @ferhui @aajisaka