HDFS-15939.Solve the problem that DataXceiverServer#run() does not record SocketTimeout exception. #2841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
liuml07
reviewed
Apr 2, 2021
| @@ -241,6 +241,13 @@ public void run() { | |||
| .start(); | |||
| } catch (SocketTimeoutException ignored) { | |||
| // wake up to see if should continue to run | |||
| if (peer != null) { | |||
| LOG.warn("A timeout occurred between DataXceiverServer: {} " + | |||
There was a problem hiding this comment.
- Let's rename the
ignoredto ste as now we are not ignoring it. - Let's not use warn level here. This seems not a concern for this timeout exception generally. I think info this level and
debugfor theelseclause should be enough?
|
💔 -1 overall
This message was automatically generated. |
…cord SocketTimeout exception.
jianghuazhu
force-pushed
the
HDFS-15939
branch
from
a569176 to
b0ed735
Compare
|
Sorry, I ignored this question for a while. I will continue to work.
|
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cord SocketTimeout exception.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute