-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-17576. ABFS: Disable throttling update for auth failures #2761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TEST RESULTS HNS Account Location: East US 2
|
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
TEST RESULTS HNS Account Location: East US 2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Configuration config = new Configuration(getRawConfiguration()); | ||
String accountName = config.get("fs.azure.abfs.account.name"); | ||
// Setup to configure custom token provider | ||
config.set("fs.azure.account.auth.type." + accountName, "Custom"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use constant for properties org.apache.hadoop.fs.azurebfs.constants.ConfigurationKeys.FS_AZURE_ACCOUNT_AUTH_TYPE_PROPERTY_NAME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with constants
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
+1 |
…he#2761) Contributed by Sumangala Patki
…he#2761) Contributed by Sumangala Patki
…ilures (apache#2761) (apache#2885) Contributed by Sumangala Patki (cherry picked from commit 6f640ab) Change-Id: I5388a21addf9cf83dadeea358171458a0d2abd2b
Throttling metrics are updated post the execution of each request. Failures related to fetching access tokens and signing requests do not occur at the Store. Hence, such operations should not contribute to the measured Store failures, and are therefore excluded from the metric update for throttling.