HDFS-15855.Solve the problem of incorrect EC progress when loading FsImage. #2741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojochuang
reviewed
Mar 8, 2021
|
According to Jenkins the only test that failed was TestBalancer, which is unrelated to this patch. |
|
@jojochuang , thanks for your comment. |
goiri
reviewed
Mar 8, 2021
| @@ -482,11 +483,15 @@ private void loadPolicy(ErasureCodingPolicyInfo info) { | |||
| * | |||
| */ | |||
| public synchronized void loadPolicies( | |||
| List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf) | |||
| List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf, | |||
There was a problem hiding this comment.
Can you leave the old header passing a null so we don't need to modify the tests?
There was a problem hiding this comment.
+1, keep the original method and parameters as followinng.
public synchronized void loadPolicies( List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf) { loadPolicies(ecPolicies, conf, null); }
| @@ -143,7 +143,7 @@ public void testChangeDefaultPolicy() throws Exception { | |||
| testPolicy); | |||
| manager.init(conf); | |||
| // Load policies similar to when fsimage is loaded at namenode startup | |||
| manager.loadPolicies(constructAllDisabledInitialPolicies(), conf); | |||
| manager.loadPolicies(constructAllDisabledInitialPolicies(), conf, null); | |||
There was a problem hiding this comment.
Can we add a test with the counter being passed?
|
@goiri , thanks for your comment. I will add some unit tests. |
Hexiaoqiao
reviewed
Mar 19, 2021
There was a problem hiding this comment.
It almost looks good to me, will give +1 from my side when add new unit test to cover the ecpolicy counter. Thanks @jianghuazhu for your works.
| @@ -482,11 +483,15 @@ private void loadPolicy(ErasureCodingPolicyInfo info) { | |||
| * | |||
| */ | |||
| public synchronized void loadPolicies( | |||
| List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf) | |||
| List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf, | |||
There was a problem hiding this comment.
+1, keep the original method and parameters as followinng.
public synchronized void loadPolicies( List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf) { loadPolicies(ecPolicies, conf, null); }
|
@Hexiaoqiao , @jojochuang , I have submitted a new solution. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Image.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute