Skip to content

YARN-10553. Refactor TestDistributedShell #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 8, 2021
Merged

YARN-10553. Refactor TestDistributedShell #2581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d13366
YARN-10553. split TestDistributedShell
amahussein Dec 31, 2020
4835b31
YARN-10553. make abstract class and optimize setup
amahussein Jan 7, 2021
0d94ca6
YARN-10533. fix yarn-site reloading bug
amahussein Jan 8, 2021
11df20a
--amend
amahussein Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ private void printUsage(Options opts) {
new HelpFormatter().printHelp("ApplicationMaster", opts);
}

private void cleanup() {
protected void cleanup() {
try {
appSubmitterUgi.doAs(new PrivilegedExceptionAction<Void>() {
@Override
Expand Down
8 changes: 3 additions & 5 deletions ...butedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1414,21 +1414,19 @@ protected void sendStopSignal() {
}
int waitCount = 0;
LOG.info("Waiting for Client to exit loop");
while (!isRunning.get()) {
while (isRunning.get()) {
try {
Thread.sleep(50);
} catch (InterruptedException ie) {
// do nothing
} finally {
waitCount++;
if (isRunning.get() || waitCount > 2000) {
if (++waitCount > 2000) {
break;
}
}
}
LOG.info("Stopping yarnClient within the Client");
LOG.info("Stopping yarnClient within the DS Client");
yarnClient.stop();
yarnClient.waitForServiceToStop(clientTimeout);
LOG.info("done stopping Client");
}
}
Loading